QA » openQA Project

coolo wrote:

Variables set in yaml need to have top priority - and then we don't need any overwrites. I see this as a bug - everywhere (including you) expect it this way

The user story's step is:

1. When openqa trigger jobs automatically (for example there is a new build), the ISO will be set. (I did not check the code, just think it according to the result, maybe I am wrong.) But for migration team, the ISO value is wrong, they want to set this value by themselves.
2. So they try to define the ISO in YAML using +ISO. As openqa's document, a setting start with + has the top priority. But our YAML does not support the settings property start with +.

I also confirmed, we just need to modify the regex ^[A-Z_]+[A-Z0-9_]*$ that defined in JobTemplates-01.yaml to ^[A-Z_+]+[A-Z0-9_]*$, it will make sense to their requirements.

And IMHO, why the variables set in YAML need to have top priority? From a QA's view, we also need to modify the setting when trigger a job using client isos post and clone_job to confirm something. If the variables set in YAML have a top priority, we need to modify the YAML file every time when we want to confirm some variables. It's not convenient.

Fair point. So the api variables overrule. But the settings in the job group yaml need to take preference over machine,testsuite and product. So the value in allowing +ISO there is to overrule even variables from command line.

coolo wrote:

Fair point. So the api variables overrule. But the settings in the job group yaml need to take preference over machine,testsuite and product. So the value in allowing +ISO there is to overrule even variables from command line.

Yes. In my test, the settings in the job group yaml have already taken preference over machine, testsuite and product.

checked myself again, works as expected. Great! Thank you.

Just for future notice, this is very important functionality for Fedora, we use it quite a bit, specifically the bit about having a value set in the templates override a value passed in by the scheduler in certain cases. So thanks for fixing it.

i just stumbled over this and saw that the settings can have a plus at the start, but not in the default settings.
Is this intended or should this also be allowed in the default settings?

I created a PR related to that: https://github.com/os-autoinst/openQA/pull/2711

That will use the same pattern for settings in the jobs and in the defaults.