action #53801
closed
[functional][y] Move 'start bootloader from read-only snapshot' selection out of 'grub_test' module
Added by oorlov almost 5 years ago.
Updated over 4 years ago.
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 29
Description
Motivation¶
Currently, grub_test.pm module contains sub boot_into_snapshot which selects 'start bootloader from snapshot' in bootloader menu (please, see the openQA step for more details).
grub_test.pm is not the right place to select bootloader menu items. The selection should be moved out of the test module.
Acceptance Criteria¶
- Move
sub boot_into_snapshot to boot_into_snapshot.pm test module (or re-think on where the right place for selection of the bootloader menu);
- Verify that
grub_test.pm is still working in all the test suites where it is scheduled;
- Verify that
boot_into_snapshot.pm (or the module, that was chosen in AC1) is still working in all the test suites where it is scheduled.
- Due date set to 2019-08-13
- Target version set to Milestone 26
- Estimated time set to 3.00 h
- Status changed from New to Workable
- Status changed from Workable to In Progress
- Assignee set to ybonatakis
i have to admit that i cant see why the grub_test is not the right place to handle this. What is misleading for me is the name of the module which indicated that is gonna be a test but from the description seems that grub_test is there to handle the booting. So IMO it would be just better to rename this module.
Otherwise i can see two outcomes.
1 - we create another module to handle the boot from the grub to the snapshot option. for me it is a problem because the grub_test is there for that very reason (unless i dont understand something)
2 - we try to move the functionality into the boot_from_snapshot. But then i think we end up with repetitive code for the grub. In this case we have also to reschedule all the jobs that contains the boot_from_snapshot removing the grub_test.
- Status changed from In Progress to Feedback
As discussed, my recommendation would be to unscheduled grub_test.pm from the test suite and move boot_into_snapshot if get_var("BOOT_TO_SNAPSHOT") to boot_into_snapshot.pm to have the graphical part of grub and the rollback all together, due to modify grub_test.pm could cost many verification if the functionality is extracted as this module is widely shared. Let's leave this ticket in feedback for someone else to through some idea.
- Assignee deleted (
ybonatakis)
- Target version changed from Milestone 26 to Milestone 27
- Due date changed from 2019-08-13 to 2019-09-10
- Status changed from Feedback to Workable
- Priority changed from Normal to Low
- Due date changed from 2019-09-10 to 2019-09-24
- Due date changed from 2019-09-24 to 2019-10-08
- Target version changed from Milestone 27 to Milestone 28
- Due date changed from 2019-10-08 to 2019-10-22
- Due date changed from 2019-10-22 to 2019-11-05
- Status changed from Workable to In Progress
- Assignee set to ybonatakis
- Status changed from In Progress to Feedback
- Target version changed from Milestone 28 to Milestone 29
- Status changed from Feedback to Rejected
As per comment in the PR, we agreed that we cannot reach what we wanted originally and ticket was misleading.
Also available in: Atom
PDF