QA » openQA Project

PR: Add test suite description for bug reporting (merged)

[16/01/2019 11:37:36] <okurz> updated o3 webui
[16/01/2019 11:38:06] <okurz> jrivera: you can check the template on o3 now, works for me :)
[16/01/2019 11:38:25] <okurz> Martchus: I updated the o3 webui, you might want to check the live log changes, e.g. wrapping
[16/01/2019 11:40:06] <okurz> Martchus: I would say wrapping works even though I was not a friend of the idea from the beginning

Hi @JERiveraMoya it seems the feature works fine on o3 but not on osd since the deployment of yesterday. E.g. see the report #46577 mentioning
"openQA test in scenario OpenQA::Schema::Result::TestSuites=HASH(0xa00d558) fails in". This seems to happen regardless if the testsuite actually has a description or not. E.g. creating a ticket from https://openqa.suse.de/tests/2393846#step/boot_to_desktop/4 which has a testsuite description seems to cause the same. But again, on o3 it works fine, in both cases of the testsuite having a description or not. Could you please take a look into this soon? I am sure nsinger and mkittler can provide help regarding the instance or debugging.

The test suite description in the example mentioned by @okurz is simply not rendered because TEST is set to offline_sles11sp4_media_ha+geo_sdk_all but there's only a testsuite called offline_sles11sp4_media_ha. I assume that everything after the plus sign should be ignored to determine the test suite description.

adapting team assignment as mkittler took over.

I'm not seriously considering to mess around on OSD for an issue like this. However, I'm also clueless how to fix it right now. So I'm removing the due date.

I better add it to our sprint then so I wouldn't forget about it.

I need to bring at least one of the staging instances in a usable state again anyways. Maybe I can reproduce the issue on the staging instance then.

fine, I will look into this myself

There was (still?) the file /etc/openqa/templates/branding/openqa.suse.de/external_reporting.html.ep which I renamed now to ….old . The diff:

# diff -Naur /usr/share/openqa/templates/branding/openSUSE/external_reporting.html.ep /etc/openqa/templates/branding/openqa.suse.de/external_reporting.html.ep.old
--- /usr/share/openqa/templates/branding/openSUSE/external_reporting.html.ep    2019-01-21 14:43:24.000000000 +0100
+++ /etc/openqa/templates/branding/openqa.suse.de/external_reporting.html.ep.old        2017-12-02 12:01:45.254850697 +0100
@@ -2,20 +2,19 @@
 % my $step_url = url_for('step')->to_abs;
 % my $module = stash('moduleid');
 % my %product_details = ();
-% my $scenario_description = $job->scenario_description // '';

 <% my %distri_to_product_url_new = (
     sle => 'https://bugzilla.suse.com/enter_bug.cgi',
     opensuse => 'https://bugzilla.opensuse.org/enter_bug.cgi',
+    casp => 'https://bugzilla.suse.com/enter_bug.cgi',
     caasp => 'https://bugzilla.suse.com/enter_bug.cgi',
-    openqa => 'https://progress.opensuse.org/projects/openqav3/issues/new',
-    kubic => 'https://bugzilla.opensuse.org/enter_bug.cgi'
+    openqa => 'https://progress.opensuse.org/projects/openqav3/issues/new'
 );%>
 <% my %distri_to_prod = (
     sle => 'SUSE Linux Enterprise',
     opensuse => 'openSUSE',
+    casp => 'SUSE Container as a Service Platform',
     caasp => 'SUSE CaaS Platform',
-    kubic => 'openSUSE'
 ); %>
 <% my %flavor_to_prod_sle = (
     Server => 'Server',
@@ -48,6 +47,9 @@
 % elsif ($job->DISTRI eq 'opensuse') {
 %     $product = $job->VERSION eq 'Tumbleweed' ? 'Tumbleweed' : 'Distribution';
 % }
+% elsif ($job->DISTRI eq 'casp') {
+%     $product = $job->VERSION;
+% }
 % elsif ($job->DISTRI eq 'caasp') {
 %     $product = $job->VERSION =~ s/\.[0-9]//r;
 % }
@@ -59,7 +61,7 @@
 %     my ($job) = @_;
 %     return '[' . $job->BUILD . '](' . url_for('test', testid => $job->id)->to_abs .  ')';
 % }
-% my $scenario = $job->scenario_name;
+% my $scenario = $job->scenario;
 % my $first_known_bad = build_link($job) . ' (current job)';
 % my $last_good = '(unknown)';
 % for my $prev ($job->_previous_scenario_jobs) {
@@ -75,9 +77,6 @@
 openQA test in scenario $scenario fails in
 [$module]($step_url)

-## Test suite description
-$scenario_description
-

 ## Reproducible

@@ -104,9 +103,6 @@
 %    $product_details{product} = "$distri $product";
 %    $product_details{bug_file_loc} = $step_url;
 % }
-% if ($distri eq 'kubic') {
-%    $product_details{component} = 'Kubic';
-% }
 % my $product_url_new = $distri_to_product_url_new{$job->DISTRI};
 % if ($product) {
     %= stepaction_for('Report product bug' => url_for($product_url_new)->query(%product_details), 'fa-bug', 'report product_bug');

which differed in the one part that matters here:

-% my $scenario = $job->scenario_name;
+% my $scenario = $job->scenario;

which can of course explain the problem as not a string was returned.

I assume this will fix the problem and we actually do not need more to do. I consider it a bit unfortunate that it took 20 days to reach this conclusion only now.