Actions
action #45008
closed[functional][u] Further improvements on splitting backend code
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 25
Start date:
2019-04-16
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Difficulty:
easy
Description
Things that can be done in the future to further separate backend specific or generic code from other packages...
Suggestions:¶
TODO: all this come from version_utils.pm, does it make sense to move them to Utils::Backends
# is_hyperv
# is_hyperv_in_gui
# is_aarch64_uefi_boot_hdd
# is_svirt_except_s390x
Checks for specific architectures can also be moved to a different package (Utils::Architectures) and opensusebasetest inheriting from it, to avoid excess of imports...
# defined in lib/version_utils.pm
# sub is_s390x {
# return check_var('ARCH', 's390x');
# }
# sub is_x86_64 {
# return check_var('ARCH', 'x86_64');
# }
- Grep for
check_var('ARCH'
(might use single or double quotes) and move these to an architecture specific utils package - grep for
'check_var("BACKEND",
(might use single or double quotes) and move these to Utils::Backends or a possibly different package to ensure that we can differentiate from utilities that help with the backend, vs utilities that add more functionality to the backend independant code (like is_remote_backend)
Actions