action #50432: [sle][functional][u] move specific architectures Utils::Architectures - openQA Tests - openSUSE Project Management Tool

Actions

Copy link

action #50432

closed

action #45008: [functional][u] Further improvements on splitting backend code

[sle][functional][u] move specific architectures Utils::Architectures

Added by zluo about 5 years ago. Updated almost 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

zluo

Category:

New test

Target version:

SUSE QA - Milestone 24

Start date:

2019-04-16

Due date:

% Done:

Estimated time:

Difficulty:

Description

create Utils::Architectures
move specific architectures to it and let opensusebasetest inheriting from it, to avoid excess of imports

Suggestions:
check like following:

# defined in lib/version_utils.pm                                                                                                                                                                                               
# sub is_s390x {                                                                                                                                                                                                                
#     return check_var('ARCH', 's390x');                                                                                                                                                                                        
# }                                                                                                                                                                                                                             
# sub is_x86_64 {                                                                                                                                                                                                               
#     return check_var('ARCH', 'x86_64');                                                                                                                                                                                       
# }

Grep for check_var('ARCH' (might use single or double quotes) and move these to an architecture specific utils package

Acceptance criteria

create Utils::Architectures and move specfici architectures to it.
all related tests work as before.

Actions

Copy link

Updated by zluo about 5 years ago

Description updated (diff)

Actions

Copy link

Updated by zluo about 5 years ago

Description updated (diff)

Actions

Copy link

Updated by zluo about 5 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by zluo about 5 years ago

Description updated (diff)

Actions

Copy link

Updated by zluo about 5 years ago

found in version_utils.pm:

sub is_s390x {
return check_var('ARCH', 's390x');
}
sub is_x86_64 {
return check_var('ARCH', 'x86_64');
}
sub is_aarch64 {
return check_var('ARCH', 'aarch64');
}
sub is_ppc64le {
return check_var('ARCH', 'ppc64le');
}

Create Utils::Architectures for these.

Actions

Copy link

Updated by zluo about 5 years ago

Description updated (diff)

Actions

Copy link

Updated by zluo almost 5 years ago

created at first:

# Copyright (C) 2019 SUSE LLC
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with this program; if not, see <http://www.gnu.org/licenses/>.
package Utils::Architectures;
use strict;
use warnings;
use base qw(Exporter);
use Exporter;
use testapi qw(:DEFAULT);
use constant {
ARCH => [
qw(
is_s390x
is_x86_64
is_aarch64
is_ppc64le
)
]
};
our @EXPORT = @{(+ARCH)};
our %EXPORT_TAGS = (
ARCH => (ARCH),
);
# specific architectures
sub is_s390x {
return check_var('ARCH', 's390x');
}
sub is_x86_64 {
return check_var('ARCH', 'x86_64');
}
sub is_aarch64 {
return check_var('ARCH', 'aarch64');
}
sub is_ppc64le {
return check_var('ARCH', 'ppc64le');
}
1;

Actions

Copy link