action #38522
closedUpdating Job Group default priority does not have effect on new tests added to that group
Added by xlai almost 6 years ago. Updated over 5 years ago.
Description
In virtualization-acceptance job group in sle12sp4, change the default priority from 50 to 30, but the tests still show priority as 50, and also after I retrigger the job via "client isos post", the priority of job is still 50.
I tried to readd the tests after setting default priority of that group to 30 suggested by sergio(this way worked for him), but the added test still shows old priority 50.
BTW, we need to evaluate the run time for this job group during beta1 with priority 30, can anyone help to change the priority if you can by anyway?
Updated by xlai almost 6 years ago
- Subject changed from [OpenQA][backend] Can not change the priority of tests in job group. to [OpenQA][webui] Can not change the priority of tests in job group.
Updated by okurz almost 6 years ago
- Project changed from openQA Tests to openQA Project
- Subject changed from [OpenQA][webui] Can not change the priority of tests in job group. to Can not change the priority of tests in job group.
- Category changed from Bugs in existing tests to Regressions/Crashes
this belongs into "openQA project"
Updated by szarate almost 6 years ago
- Priority changed from High to Normal
@alice, I did the change in the database. Will set the priority to normal for now.
Updated by szarate almost 6 years ago
- Subject changed from Can not change the priority of tests in job group. to Updating Job Group default priority does not have effect on new tests added to that group
Current workaround would be to remove the medium and re-add it, along with the tests
Updated by mkittler over 5 years ago
Let me summarize the current behavior:
- The default priority set on job group level is used when
- adding new jobs within that group via
jobs postto set the job's prio. - adding new medium as part of the group to set the job template's prio.
- adding new jobs within that group via
- When using
isos post, the prio from the job template is used and not the prio on job group level. - If you add a new test within an existing medium you always get the prio 50. That is clearly a bug.
So I would first fix point 3 and make the priority of a job template editable.
Beside that, how would you like amending multiple job template priorities to work (to apply a new default)? Suggestions:
- Add a way to update the priority of all existing job templates within a group.
- Another option would be making the prio on job template level being inherited from the job group unless explicitly overridden. So if you change the prio on job group level, the job templates where the prio hasn't been explicitly overridden would be updated automatically. However, that would require to distinguish between 'explicitly set prio' and 'inherited prio' which would complicate things (especially making that clear in the UI).
Updated by mkittler over 5 years ago
- Status changed from New to In Progress
Updated by mkittler over 5 years ago
I've implemented it now in terms of inheritance (2nd suggestion of my previous comment). I'm just using the placeholder text to show the inherited value in the UI. I've also updated the help popover beside the default priority setting.
Updated by xlai over 5 years ago
mkittler wrote:
I've implemented it now in terms of inheritance (2nd suggestion of my previous comment). I'm just using the placeholder text to show the inherited value in the UI. I've also updated the help popover beside the default priority setting.
Thanks for help taking it.
With the fix, future newly posted jobs on openqa.suse.de should have default priority in the job group, right? So great news for us! When do you expect the fix to be deployed on osd? Seems currently not yet as our newly added jobs still have 50 prio, not default 30.
Updated by mkittler over 5 years ago
Seems currently not yet
@xlai So far it isn't even merged on the master branch. I'm not responsible for deploying on OSD. Not sure when we deploy the next time and whether the PR has been merged by that time. To find out whether my changes are present on an instance, I often just use the changelog.
With the fix, future newly posted jobs on openqa.suse.de should have default priority in the job group, right?
Newly posted jobs will have the default priority of the job template and the job template defaults to the job group. So it is still possible to set the prio on job template level. And the job templates present on OSD will unfortunately still have the prio set explicitly. But the UI allows to change the job template prio now and also to unset the prio so the job group default is used instead. That must be done manually for each job template which has been created before this PR if wanted. If it is to annoying to configure this manually via the UI, we could alter the database directly for this one-time-reconfiguration.
Updated by xlai over 5 years ago
mkittler wrote:
Seems currently not yet
@xlai So far it isn't even merged on the master branch. I'm not responsible for deploying on OSD. Not sure when we deploy the next time and whether the PR has been merged by that time. To find out whether my changes are present on an instance, I often just use the changelog.
Ok, I will follow up changelog.
With the fix, future newly posted jobs on openqa.suse.de should have default priority in the job group, right?
Newly posted jobs will have the default priority of the job template and the job template defaults to the job group. So it is still possible to set the prio on job template level. And the job templates present on OSD will unfortunately still have the prio set explicitly. But the UI allows to change the job template prio now and also to unset the prio so the job group default is used instead. That must be done manually for each job template which has been created before this PR if wanted. If it is to annoying to configure this manually via the UI, we could alter the database directly for this one-time-reconfiguration.
We are adding more and more tests on job groups. So we may need to change it ourselves. Thank you all the same for offering the option to change database.
Would you please give the UI link on osd that allows to change the job template prio? I know job template can be downloaded via dump_template script and the UI to set job group prio, but not sure where the UI for template prio is.
Updated by mkittler over 5 years ago
The UI would be the prio column eg. on https://openqa.suse.de/admin/job_templates/139. But so far you can't change it. Even if you create a new row you can't change it (not sure whether it was always like that). Making this column editable is part of the PR for this ticket (which hasn't been merged and deployed).
Updated by xlai over 5 years ago
mkittler wrote:
The UI would be the prio column eg. on https://openqa.suse.de/admin/job_templates/139. But so far you can't change it. Even if you create a new row you can't change it (not sure whether it was always like that). Making this column editable is part of the PR for this ticket (which hasn't been merged and deployed).
Got it. I will wait for it being merged then. Hope soon :) Thank you for the quick fix!
@szarate When do you think this PR can be merged and deployed? This is important for timely acceptance testing result.
Updated by mkittler over 5 years ago
- Status changed from In Progress to Feedback
The PR has been merged and coolo said he would like to deploy on Monday.
Updated by mkittler over 5 years ago
- Status changed from Feedback to Resolved
Changes have been deployed on osd and it seems to work.