QA (public) » openQA Project (public)

Likely easy to implement since we have this already for failed modules.

This WIP branch already allows to do this via the client: https://github.com/Martchus/openQA/tree/filter_by_module_name

eg. script/client jobs build=20180521 modules=welcome

Do you really think this is not a feature for openQA? Are you thinking about an external tool? Is this the same as #34486 ?

@okurz said:

Do you really think this is not a feature for openQA? Are you thinking about an external tool? Is this the same as #34486 ?

Currently we have an ability to search for failed modules using Filter section on “Test result overview” Page.

This ticket is a request for a search by modules regardless of their status. So, this requires just another query to DB (which seems to be already done by @mkittler) and small changes in UI (like adding new text field or editing existing one).

#34486 seems more complicated and general, but I guess we can count this ticket as a part of the #34486.

oorlov wrote:

#34486 seems more complicated and general

Yes, probably also because of the comments from different people to make it more complicated ;)

https://github.com/okurz/scripts/blob/master/openqa-db_query_last_use_of_module can do it already as a "hacky external script", could be helpful as reference.

Your PR is nice but it only works as a filter starting from an existing test overview, right? So how would I be able to search "in all job groups" as your user story describes?

@okurz, the filter works on any amount of Job Groups. Just run it on a page where all Job Groups are shown (e.g. https://openqa.suse.de/tests/overview?distri=sle&version=15-SP1&build=144.3&groupid=110&groupid=111&groupid=118&groupid=129&groupid=112&groupid=113&groupid=114&groupid=115&groupid=213&groupid=116&groupid=117&groupid=130&groupid=133&groupid=143&groupid=146&groupid=156&groupid=222&groupid=219).

Well, but wasn't the original problem that we break tests in other products, e.g. maintenance tests? The other job groups of the same products are less likely to show the test modules failing.

The feature can now be observed in production on e.g. https://openqa.opensuse.org/tests/overview?arch=&modules=keymap_or_locale&modules_result=failed&distri=kubic&distri=opensuse&version=Tumbleweed&build=20190121&groupid=1#

@oorlov @mkittler what I find confusing now from UX point of view is that we have check boxes for "Result" and a multi-selection field for "Module Result". Looks a bit inconsistent. Do you have ideas how to improve that?

Hey, have you seen my comment #38024#note-23 or missed it? We can also talk about it personally if you prefer.

Oliver, sorry for late reply. Didn't see the comment above.

Probably you just misunderstood on how the search by modules is implemented.

It searches through any amount of job groups. You just need to stay on the page where all the needed groups are shown.

For example, you may search in only "Functional: Server" job group for Sle12 build 0120: https://openqa.suse.de/tests/overview?distri=sle&version=12-SP5&build=0120&groupid=139

Or you can even search among all the Sle15 and Sle12 groups. Just go to the page where all the jobs of the groups are listed: https://openqa.suse.de/tests/overview?distri=sle&version=12-SP5&build=0120&version=15-SP1&build=159.1

So it's up to you where to call the filter.

The only thing is the database (or queries) are slow and on huge amount of data there might be Gateway Error. But it is another thing and it should be done in scope of another tasks.

oorlov wrote:

Oliver, sorry for late reply. Didn't see the comment above.

Well, thanks for finding it. Lately some people did not see notifications and have not realized comments. You did :)

Probably you just misunderstood on how the search by modules is implemented.

Well, I doubt I misunderstood in this case, also as I have implemented the multi-job-group view :)

You have added a nice and helpful feature, I am not questioning that but I wonder how we can go on, as in #38024#note-23 :

Well, but wasn't the original problem that we break tests in other products, e.g. maintenance tests? The other job groups of the same products are less likely to show the test modules failing.

Isn't this what also happened in the past and looking in multiple job groups of the same build will not help?

It would be nice if

https://openqa.opensuse.org/tests/overview?modules=keymap_or_locale&result=failed

would help us to return all the failed jobs where this module was scheduled and it kinda does but hardly how people would expect it to work as it can show jobs that are about 10 months old as the job resolution depends on the order, do we look for "last failed" first, then for the module and then for the build or in different order?

In any case, isn't your PR https://github.com/os-autoinst/openQA/pull/1993 still related to this ticket? Maybe it would be good to have a follow-up ticket? I would be happy to follow-on with you to find the next best step.