QA » openQA Project » openQA Tests

I think github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4908 did not fix this completely

Code behaves like this now:

[2018-06-08T08:01:26.0642 UTC] [debug] /var/lib/openqa/cache/openqa1-opensuse/tests/opensuse/tests/x11/shutdown.pm:24 called testapi::x11_start_program
[2018-06-08T08:01:26.0642 UTC] [debug] <<< testapi::assert_screen(mustmatch=[
  'xterm',
  'desktop-runner-plasma-suggestions'
], no_wait=0, timeout=90)
[2018-06-08T08:01:26.0672 UTC] [debug] MATCH(xterm-started-20150325:0.00)
[2018-06-08T08:01:26.0700 UTC] [debug] MATCH(xterm-started-20150430:0.00)
[2018-06-08T08:01:26.0726 UTC] [debug] MATCH(xterm-started-20170125:0.00)
[2018-06-08T08:01:26.0756 UTC] [debug] MATCH(xterm-started-kde-20171111:0.00)
[2018-06-08T08:01:26.0781 UTC] [debug] MATCH(desktop-runner-plasma-suggestions-20180423:1.00)
[2018-06-08T08:01:26.0924 UTC] [debug] >>> testapi::_handle_found_needle: found desktop-runner-plasma-suggestions-20180423, similarity 1.00 @ 243/1
[2018-06-08T08:01:26.0924 UTC] [debug] /var/lib/openqa/cache/openqa1-opensuse/tests/opensuse/tests/x11/shutdown.pm:25 called testapi::script_sudo
[2018-06-08T08:01:26.0925 UTC] [debug] <<< testapi::script_sudo(name='echo \'ForwardToConsole=yes\' >> /etc/systemd/journald.conf', wait=2)

so somehow the test is accepting "desktop-runner-plasma-suggestions" and not actually waiting for an xterm window but it should.

The relevant test code is in lib/susedistribution.pm:

    my @target = ref $args{target_match} eq 'ARRAY' ? @{$args{target_match}} : $args{target_match};
    for (1 .. 3) {
        push @target, check_var('DESKTOP', 'kde') ? 'desktop-runner-plasma-suggestions' : 'desktop-runner-border';
        assert_screen([@target], $args{match_timeout}, no_wait => $args{match_no_wait});
        last unless (match_has_tag 'desktop-runner-border' || match_has_tag 'desktop-runner-plasma-suggestions');
        wait_screen_change {
            send_key 'ret';
        };
    }
    # asserting program came up properly
    die "Did not find target needle for tag(s) '@target'" if (match_has_tag 'desktop-runner-border' || match_has_tag 'desktop-runner-plasma-suggestions');

I assumed this would make sure that "xterm" has to be displayed as the last screen or the die would be called but that does not seem to be the case.

Logic needs to be re-evaluated.

It's hackweek time!

already on it to look into the behaviour of desktop runner

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5409 is applied but still the test scenario is very unstable. The latest job https://openqa.opensuse.org/tests/710661#step/reboot_plasma5/10 e.g. shows the frowning smiley in systray showing a crashed application. The screen should match as soft_fail, not green after a bug has been reported, more data to this should be recorded, e.g. post_fail_hook. But first I recommend in https://openqa.opensuse.org/tests/710661#step/shutdown/10 to execute a post_fail_hook to gather data from the still active system.

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5314 from @oorlov should be the first step

bulk move to next sprint as could not be discussed in SR

I've investigated the issue with shutdown and it didn't fail for the last 15 days. Also after adding 'cleanup_before_shutdown' module, there is no xterm call in 'shutdown.pm' anymore. So the behavior from the description is not reproducible. It fails on 'assert_shutdown' instead now.

I've added DEBUG_SHUTDOWN parameter. Will wait for the statistics and more detailed logs.

let's discuss the state offline

So, I'm closing the ticket as the issue is not reproduced anymore. Also, the scope is changed - there is no xterm call in 'shutdown' module anymore.