QA (public) » openQA Project (public)

And by "os-autoinst version" I mean "os-autoinst RPM package version". My use case is to know when to merge test code which depends on os-autoinst code being deployed.

coolo wrote:

we won't display the RPM version. We have ISOTOVIDEO_INTERFACE_VERSION that needs to be increased for testapi changes - and is displayed on the workers page as property right now.

So what's missing is having somewhere which os-autoinst version the openqa is expecting, something like this in the footer:

openQA is licensed GPL-2.0 - Version 4.5.1520515419.c3df6f91 os-autoinst: 8

The ISOTOVIDEO_INTERFACE_VERSION doesn't provide enough granularity to know if the worker is up to date or not. Example:
https://github.com/os-autoinst/os-autoinst/commits/master/isotovideo

As we can see, the version was bumped to version 7 in 27 jan 2017, meanwhile there has been lots of changes. Until a pr i have open is merged, which bumps to version 8, there's no way to know if the worker have version 7 from 27 jan 2017 or version 7 from jan 2018.

What Michal wants (or what i think he wants... :-P ), requires that we need change our behaviour and start bump the isotovideo interface more often and constantly everytime that there's a commit into the os-autoinst

Regarding the other feature Michal required, i made a PR to print the isotovideo version into the logs.

os-autoinst already provides the version via --version parameter. The name of the VERSION field in the admin/workers route refers to ISOTOVIDEO_INTERFACE_VERSION, but it should be updated only when there are API changes. Not with every commit (At least not I don't think so), unless the commit change the behaviour of the API and that is another story since it's modifying or adding functionality.

I would add the output of isotovideo::version() just for the sake of completeness of the logs

szarate wrote:

os-autoinst already provides the version via --version parameter. The name of the VERSION field in the admin/workers route refers to ISOTOVIDEO_INTERFACE_VERSION, but it should be updated only when there are API changes. Not with every commit (At least not I don't think so), unless the commit change the behaviour of the API and that is another story since it's modifying or adding functionality.

I agree with you, but that doesn't address Michal's concerns.

I would add the output of isotovideo::version() just for the sake of completeness of the logs

https://github.com/os-autoinst/openQA/pull/1613

dasantiago wrote:

szarate wrote:

os-autoinst already provides the version via --version parameter. The name of the VERSION field in the admin/workers route refers to ISOTOVIDEO_INTERFACE_VERSION, but it should be updated only when there are API changes. Not with every commit (At least not I don't think so), unless the commit change the behaviour of the API and that is another story since it's modifying or adding functionality.

I agree with you, but that doesn't address Michal's concerns.

I would add the output of isotovideo::version() just for the sake of completeness of the logs

https://github.com/os-autoinst/openQA/pull/1613

I closed the previous PR, and created this one against os-autoinst: https://github.com/os-autoinst/os-autoinst/pull/939

It should give developers and testers some more info.