action #7086

add some worker version check

Added by lnussel about 5 years ago. Updated about 2 years ago.

Status:ResolvedStart date:26/02/2018
Priority:NormalDue date:
Assignee:dasantiago% Done:

100%

Category:Feature requests
Target version:Done
Difficulty:
Duration:

Description

the worker should have some kind of version that the webui can check. the webui should then be able to reject workers that are not sufficiently new. that helps in case of protocol changes or new mandatory features.


Subtasks

action #32260: Improve worker version checking.Resolveddasantiago


Related issues

Related to openQA Project - action #26890: Warn users about version incompatibility Rejected 19/10/2017
Related to openQA Project - action #29250: [tools] Error on journalctl - [worker:error] got unknown ... Rejected 11/12/2017
Related to openQA Project - action #30002: Provide currently installed os-autoinst version in openQA... Resolved 05/01/2018

History

#1 Updated by okurz about 4 years ago

  • Category set to 132

#2 Updated by coolo about 4 years ago

  • Priority changed from High to Normal

this is not actually of high priority as we just have to be careful when deploying new versions to deploy all machines. Annoying, but not critical

#3 Updated by coolo about 4 years ago

I think we also need a stricter check on using the same os-autoinst on the workers. But possibly if the worker required the os-autoinst version it was built against, we could sync this issue with that other problem.

#4 Updated by okurz over 2 years ago

  • Related to action #26890: Warn users about version incompatibility added

#5 Updated by coolo over 2 years ago

  • Target version set to Ready

#6 Updated by coolo over 2 years ago

  • Related to action #29250: [tools] Error on journalctl - [worker:error] got unknown command info added

#7 Updated by EDiGiacinto about 2 years ago

Just my 2c on this:

Aside from displaying workers versions: i think for a communication protocol perspective (especially wrt websocket server/worker) is a good thing to have also a variable/constant identifying only the protocol version - inside the codebase - instead of the packaging version.
That allows us with a bit of more control and we can bump the protocol version number inside the code when we know we are breaking compatibility with our changes and let the worker immediately die in such case.

#9 Updated by EDiGiacinto about 2 years ago

  • Related to action #30002: Provide currently installed os-autoinst version in openQA worker page and log added

#10 Updated by EDiGiacinto about 2 years ago

okurz wrote:

like https://github.com/os-autoinst/os-autoinst/blob/master/isotovideo#L55 ?

yup, i think we should do the same for the websocket/internal commands

#12 Updated by dasantiago about 2 years ago

  • Assignee set to dasantiago

#13 Updated by dasantiago about 2 years ago

  • Target version changed from Ready to Current Sprint

#14 Updated by dasantiago about 2 years ago

  • Status changed from New to In Progress

#15 Updated by dasantiago about 2 years ago

  • Status changed from In Progress to Resolved

This has been into production since 16/02/2018.

#16 Updated by szarate about 2 years ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF