action #26836
closedcoordination #18964: [functional][epic][u]Bootloader/boot functions refactor
[sle][functional][s390x][u][easy] Adjust reconnect_s390 and wait_boot to always wait for grub menu and send 'ret'
0%
Description
goal¶
Align s390x special boot handling to other architectures to have less specialization where not needed
acceptance criteria¶
- AC1: s390x checks for grub menu and sends 'ret' to boot first entry like on other architectures
- AC2: the workaround for s390x in tests/installation/disable_grub_timeout.pm is removed
tasks¶
- Review tests/installation/reconnect_s390.pm and understand its purpose (1-2h)
- Optional: Merge reconnect_s390 with first_boot and/or boot_to_desktop (1-4h)
- In opensusebasetest::wait_boot for
if (check_var('BACKEND', 's390x'))
wait for grub usingexpect_3270
and send 'ret'/'ENTER' to do the same as for zkvm/s390x-kvm (2-8h) - Call the same code as
wait_boot
infirst_boot
(2-12h) - Remove s390x workaround in tests/installation/disable_grub_timeout.pm
further details¶
This ticket could be split for s390x-zVM and s390x-kvm
Also see https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/3740
Caused by #25658
Updated by okurz over 6 years ago
- Due date set to 2018-04-10
- Target version changed from Milestone 14 to Milestone 15
can wait a bit longer after SLE 15 RC1
Updated by okurz over 6 years ago
- Due date changed from 2018-04-10 to 2018-05-08
not enough capacity in S14, moving
Updated by mgriessmeier over 6 years ago
- Subject changed from [sle][functional][s390x] Adjust reconnect_s390 and wait_boot to always wait for grub menu and send 'ret' to [sle][functional][s390x][u] Adjust reconnect_s390 and wait_boot to always wait for grub menu and send 'ret'
Updated by mgriessmeier over 6 years ago
- Target version changed from Milestone 15 to Milestone 16
Updated by okurz over 6 years ago
- Subject changed from [sle][functional][s390x][u] Adjust reconnect_s390 and wait_boot to always wait for grub menu and send 'ret' to [sle][functional][s390x][u][easy] Adjust reconnect_s390 and wait_boot to always wait for grub menu and send 'ret'
- Difficulty set to easy
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4887/commits/0dcccea73cc8d9f8db39bc5b6c13c0d2f2b979e5 covers this for z/VM as well. What we should do is crosscheck if the grub boot menu is explicitly confirmed now in the following cases:
- z/VM installation
- kvm installation
- kvm boot image
That should be easily checkable from log files.
Updated by mgriessmeier about 6 years ago
- Due date changed from 2018-05-08 to 2018-05-22
Updated by oorlov about 6 years ago
- Status changed from Workable to In Progress
Updated by SLindoMansilla about 6 years ago
As spoken with oorlov
Job examples for the differents cases:
- z/VM: https://openqa.suse.de/tests/1679604
- kvm (zkvm / SUSEkvm)
- installation: https://openqa.suse.de/tests/1681297
- boot from hdd: https://openqa.suse.de/tests/1681801
mgriessmeier, please correct me if I am wrong.
Updated by oorlov about 6 years ago
After investigations with mgriessmeier, it was found that grub boot menu is explicitly confirmed for z/VM, but not for kvm.
I'll investigate what could be done in order to fix this.
Updated by oorlov about 6 years ago
- Status changed from In Progress to Feedback
PR with fixes for kvm added: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5116
Updated by mgriessmeier about 6 years ago
- Due date changed from 2018-05-22 to 2018-06-05
Updated by mgriessmeier about 6 years ago
- Due date changed from 2018-06-05 to 2018-06-19
- Target version changed from Milestone 16 to Milestone 17
PR is opened - but valid propose to postpone merge until GMC Phase is over, moving to next sprint
Updated by okurz about 6 years ago
- Target version changed from Milestone 17 to Milestone 17
Updated by mgriessmeier about 6 years ago
- Due date changed from 2018-06-19 to 2018-07-03
PR is still under review/discussion - moving
Updated by mgriessmeier about 6 years ago
- Due date changed from 2018-07-03 to 2018-07-31
Updated by okurz about 6 years ago
- Status changed from Feedback to Resolved
The PR was merged and I think also subsequent fixes. I guess we are good here. The workaround in disable_grub_timeout has been removed. https://openqa.suse.de/tests/1816647/file/serial0.txt seems to show that the grub menu shows up fine and is handled accordingly.