action #176826
opencoordination #154768: [saga][epic][ux] State-of-art user experience for openQA
coordination #154771: [epic] Improved test developer user experience
Automatic label link is "broken" when job link is followed from the issue creation preview size:S
0%
Description
Observation¶
When a new issue linking a test is to be created, but not yet saved, the automatic label link from the comment to the issue links to the issue creation form. See https://openqa.opensuse.org/tests/4842740#comment-710485 which should be an automatic comment created for #176820 - instead it says https://progress.opensuse.org/projects/openqatests/issues/new?issue%5Bcategory_id%5D=152&issue%5Bsubject%5D=test+fails+in+reproducer&issue%5Bdescription%5D=%23%23+Observation%0A%0AopenQA+test+in+scenario+openqa-Tumbleweed-dev-x86_64-openqa_install_nginx%40os-autoinst%2Fos-autoinst-distri-openQA%23reproducer%4064bit-2G+fails+in%0A%5Breproducer%5D%28https%3A%2F%2Fopenqa.opensuse.org%2Ftests%2F4842740%2Fmodules%2Freproducer%2Fsteps%2F4%29%0A%0A%23%23+Test+suite+description%0A%0A%0A%0A%23%23+Reproducible%0A%0AFails+since+%28at+least%29+Build+%5Bos-autoinst%2Fos-autoinst-distri-openQA%23reproducer%5D%28https%3A%2F%2Fopenqa.opensuse.org%2Ftests%2F4842739%29%0A%0A%0A%23%23+Expected+result%0A%0ALast+good%3A+%28unknown%29+%28or+more+recent%29%0A%0A%0A%23%23+Further+details%0A%0AAlways+latest+result+in+this+scenario%3A+%5Blatest%5D%28https%3A%2F%2Fopenqa.opensuse.org%2Ftests%2Flatest%3Farch%3Dx86_64%26distri%3Dopenqa%26flavor%3Ddev%26machine%3D64bit-2G%26test%3Dopenqa_install_nginx%2540os-autoinst%252Fos-autoinst-distri-openQA%2523reproducer%26version%3DTumbleweed%29%0A
Acceptance criteria¶
- AC1: No comment is created when so far a wrong one with a "new issue" link would be created.
Suggestion¶
- Check that the referer is an issue URL and e.g. not new issue or other types of URLs
- Use a mapping from bug trackers to an issue regex
- This could affect other bug trackers? Does this happen with Bugzilla?
- Code: sub mark_job_linked https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Schema/ResultSet/Jobs.pm#L468
- Extend test: https://github.com/os-autoinst/openQA/blob/master/t/10-jobs-referal.t
Files
Updated by tinita 2 months ago ยท Edited
Test link: https://openqa.opensuse.org/tests/4842739#step/reproducer/1
edit: looks ok to me: https://openqa.opensuse.org/tests/4842739#comment-710578
label:linked Job mentioned in https://progress.opensuse.org/issues/176826
Updated by tinita 2 months ago
@jbaier_cz for https://openqa.opensuse.org/tests/4842740#comment-710485 it looks like you clicked the link to the job when creating the ticket and hitting "Preview"?
The link is not "broken", it's just the link for creating a new issue. I think it has nothing to do with the project the issue is created in.
We might want to prevent such "create issue" links, though.
Updated by livdywan 2 months ago
- Subject changed from Automatic label link is "broken" when job link is followed from the issue creation preview to Automatic label link is "broken" when job link is followed from the issue creation preview size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by ybonatakis about 1 month ago
So the request has Referer
https://progress.opensuse.org/projects/suseqa/issues/new
as long as the ticket is still new and is not created.
A workaround is after to save the issue, delete the comment and refresh.
I am looking into referer_check of Test Controller. Maybe it can be used to check whether is a proper expecting link with a regex. But I wonder for now how can I know that this will be valid for all the recognized_referers!
one way is to check issue_id in the progress post request. This parameter is not passed if the ticket is new. But I have to check the other bug trackers
Updated by ybonatakis about 1 month ago
- Status changed from Workable to In Progress
I tried to reproduce it on https://bugzilla.suse.com but I couldnt.
Steps:
- Edit a new bug https://bugzilla.suse.com/enter_bug.cgi?product=Test%20product
- copy in the description https://openqa.opensuse.org/tests/4895533
- Go to
previewand check the POST request. I foundhttps://bugzilla.suse.com/enter_bug.cgi?product=Test%20producton Referer but it doesnt send any comment on the test - Once I actually created the bug the Referer was
https://bugzilla.suse.com/show_bug.cgi?id=1238487(However still no comment on the test)
Note:
checked ariel
31:recognized_referers = bugzilla.suse.com bugzilla.opensuse.org bugzilla.novell.com bugzilla.microfocus.com progress.opensuse.org github.com build.suse.de
Updated by ybonatakis about 1 month ago
- Copied to action #178267: No label links from Bugzilla in the test comments added
Updated by ybonatakis about 1 month ago
- Status changed from In Progress to Workable
need to switch to another ticket to finish. You are welcome to take over if you want it
Updated by livdywan about 1 month ago
- Assignee deleted (
ybonatakis)
Yannis asked to be unassigned when we talked about it in the daily.
ybonatakis wrote in #note-9:
I tried to reproduce it on https://bugzilla.suse.com but I couldnt.
Note that unit tests can easily reproduce this.
Updated by tinita about 1 month ago
I mentioned to @ybonatakis earlier that this can simply be done by writing tests: https://github.com/os-autoinst/openQA/blob/master/t/10-jobs-referal.t
Updated by ybonatakis about 1 month ago
- Status changed from Workable to In Progress
- Assignee set to ybonatakis
Updated by ybonatakis about 1 month ago
https://github.com/os-autoinst/openQA/pull/6287
I tried to generalize the solution. but not sure if this is what we want as this presumes an existing issue in place
Updated by ybonatakis about 1 month ago
just side-effect changes https://github.com/os-autoinst/openQA/pull/6288
Updated by tinita about 1 month ago
- Copied to action #178771: [beginner][easy] Support for custom bugrefs (e.g. with configurable sections) added
Updated by tinita about 1 month ago
I created a more general proposal here: #178771
Updated by okurz about 1 month ago
- Status changed from In Progress to Blocked
- Assignee changed from ybonatakis to okurz
- Target version changed from Ready to future
Updated by tinita about 1 month ago
- Description updated (diff)
- Category changed from Regressions/Crashes to Feature requests
Adjusted description to make clear it's not a bug and does not depend on the project in Progress.