Project

General

Profile

Actions
Copy link

action #176820

closed

force_soft_failure does not override status to softfail in post_fail_hook size:S

Added by jbaier_cz 20 days ago. Updated 9 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
mkittler
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2025-02-09
Due date:
% Done:

0%

Estimated time:

Description

Observation

See documentation for force_soft_failure:

Similar to record_soft_failure but can be used to override the test module status to softfail from a post_fail_hook if the module would be set to fail otherwise. This can be used for easier tracking of known issues without needing to handle failed tests a lot.

However as can be seen in reproducer this does not work.

Expected result

The result of the module and job in reproducer is softfailed and not failed.

Acceptance Criteria

  • AC1: force_soft_failure overrides the job result when called from a post_fail_hook

Further details

  • force_soft_failure is only used in osado to turn passing modules into soft-failing ones so maybe this limitation has never been spotted.
Actions
Copy link
 #1

Updated by jbaier_cz 20 days ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by livdywan 16 days ago

  • Subject changed from force_soft_failure does not override status to softfail in post_fail_hook to force_soft_failure does not override status to softfail in post_fail_hook size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by mkittler 10 days ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions
Copy link
 #4

Updated by mkittler 10 days ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #5

Updated by mkittler 9 days ago

  • Status changed from Feedback to Resolved

The PR has been merged.

Actions
Copy link

Also available in: Atom PDF