Project

General

Profile

Actions

action #169159

closed

Allow variable expansion incorporating worker settings size:S

Added by mkittler 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Feature requests
Target version:
Start date:
2024-10-31
Due date:
% Done:

0%

Estimated time:
Tags:

Description

Motivation

This would be useful so job settings referring to assets (e.g. QA_HEAD_REPO=https://download.suse.de/ibs/…) could be written in a more generic way (e.g. QA_HEAD_REPO=https://%REPO_MIRROR_HOST%/ibs/…). This way the download server could be replaced by a mirror more easily. Considering ideas like https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/924 it would be useful if worker settings are considered as well. See https://suse.slack.com/archives/C02CANHLANP/p1730383116044599 for the related discussion with @szarate.
This allows convenient variable evaluation in the worker so that we do not need to do that in test code, e.g. osado, in various place.

Acceptance criteria

  • AC1: Placeholders in job settings are substituted taking settings from the worker config into account.
  • AC2: The variable substitution introduced via AC1 is in-line with https://open.qa/docs/#_variable_expansion (and internally uses the same code as much as possible).

Suggestions

  • Check what function is used to implement placeholders. Invoke that function in isotovideo.pm in the openQA-worker as well before the asset handling is done.
  • The webUI already replaces variables. We could keep variables
  • Consider a default value, e.g. %REPO_MIRROR_HOST:my.default.host% so that we don't need to set variables on all workers. The default must then only be evaluated in the Last Instance (!) wherever that is, possibly worker. As alternative os-autoinst can be used.

Further details

  • This feature is intended e.g. to be used with SLE maintenance tests so also qem-bot would need to be changed to only set a variable, possibly with default value
  • For the purpose of OSD this feature only is usable if non-CC OSD workers have access to openqa.suse.de webUI, e.g. need other currently open tickets from https://progress.opensuse.org/issues?parent_id=~165282&set_filter=true&status_id=o
  • The initial part about "before the worker cache asset download" does not make sense because worker asset caching only downloads assets from OSD, never from external resources so variable expansion is not useful there

Related issues 1 (0 open1 closed)

Related to openQA Tests (public) - action #168097: [qe-core] Make openqa.suse.de tests work with mirrors instead of dist.suse.de or download.suse.deResolveddzedro2024-11-28

Actions
Actions

Also available in: Atom PDF