action #167926
open
coordination #127031: [saga][epic] openQA for SUSE customers
coordination #130414: [epic] Improved code coverage in os-autoinst
Cover code of os-autoinst path autotest.pm fully (statement coverage) size:S
Added by okurz 2 months ago.
Updated 3 days ago.
Category:
Feature requests
Description
Acceptance criteria¶
- AC1: the path autotest.pm is listed in codecov.yml under "fully_covered"
Suggestions¶
Files
- Copied from action #167923: Cover code of os-autoinst path script/ fully (statement coverage) added
- Copied to action #167929: Cover code of os-autoinst path testapi.pm fully (statement coverage) size:M added
- Parent task changed from #167917 to #130414
- Subject changed from Cover code of os-autoinst path autotest.pm fully (statement coverage) size:M to Cover code of os-autoinst path autotest.pm fully (statement coverage)
- Target version changed from future to Ready
- Subject changed from Cover code of os-autoinst path autotest.pm fully (statement coverage) to Cover code of os-autoinst path autotest.pm fully (statement coverage) size:S
- Status changed from New to Workable
- Status changed from Workable to In Progress
- Assignee set to gpathak
Attached code coverage generated html file.
It's just, I am unable to understand how to test subrouties calling _exit() at the end.
@okurz @mkittler Please review the attached code coverage. If it looks okay, I will then mark the Pull request ready for merging.
- Status changed from In Progress to Resolved
- Status changed from Resolved to In Progress
nope. Just because a PR is merged doesn't mean that the goal is reached. Please check again.
Indeed. There's uncovered bits visible on Codecov.
gpathak wrote in #note-9:
Attached code coverage generated html file.
It's just, I am unable to understand how to test subrouties calling _exit() at the end.
@okurz @mkittler Please review the attached code coverage. If it looks okay, I will then mark the Pull request ready for merging.
I couldn't find a way to catch _exit() in unit tests. I will try to find any existing test implementation.
Also available in: Atom
PDF