Project

General

Profile

Actions
Copy link

action #167926

open

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #130414: [epic] Improved code coverage in os-autoinst

Cover code of os-autoinst path autotest.pm fully (statement coverage) size:S

Added by okurz 2 months ago. Updated 3 days ago.

Status:
In Progress
Priority:
Low
Assignee:
gpathak
Category:
Feature requests
Target version:
Ready
Start date:
2024-10-08
Due date:
% Done:

0%

Estimated time:

Description

Acceptance criteria

  • AC1: the path autotest.pm is listed in codecov.yml under "fully_covered"

Suggestions

Files

coverage.html (8.23 KB) coverage.html gpathak, 2024-12-17 14:47

Related issues 2 (1 open — 1 closed)

Copied from openQA Project (public) - action #167923: Cover code of os-autoinst path script/ fully (statement coverage)Blockedokurz2024-10-08

Actions
Copied to openQA Project (public) - action #167929: Cover code of os-autoinst path testapi.pm fully (statement coverage) size:MResolvedmkittler2024-10-08

Actions
Actions
Copy link
 #1

Updated by okurz 2 months ago

  • Copied from action #167923: Cover code of os-autoinst path script/ fully (statement coverage) added
Actions
Copy link
 #2

Updated by okurz 2 months ago

  • Copied to action #167929: Cover code of os-autoinst path testapi.pm fully (statement coverage) size:M added
Actions
Copy link
 #3

Updated by okurz 2 months ago

  • Parent task changed from #167917 to #130414
Actions
Copy link
 #4

Updated by okurz 22 days ago

  • Subject changed from Cover code of os-autoinst path autotest.pm fully (statement coverage) size:M to Cover code of os-autoinst path autotest.pm fully (statement coverage)
Actions
Copy link
 #5

Updated by okurz 15 days ago

  • Target version changed from future to Ready
Actions
Copy link
 #6

Updated by okurz 9 days ago

  • Subject changed from Cover code of os-autoinst path autotest.pm fully (statement coverage) to Cover code of os-autoinst path autotest.pm fully (statement coverage) size:S
  • Status changed from New to Workable
Actions
Copy link
 #7

Updated by gpathak 5 days ago

  • Status changed from Workable to In Progress
  • Assignee set to gpathak
Actions
Copy link
 #9

Updated by gpathak 4 days ago

Attached code coverage generated html file.
It's just, I am unable to understand how to test subrouties calling _exit() at the end.
@okurz @mkittler Please review the attached code coverage. If it looks okay, I will then mark the Pull request ready for merging.

Actions
Copy link
 #10

Updated by gpathak 3 days ago

  • Status changed from In Progress to Resolved

Pull request merged.

Actions
Copy link
 #11

Updated by okurz 3 days ago

  • Status changed from Resolved to In Progress

nope. Just because a PR is merged doesn't mean that the goal is reached. Please check again.

Actions
Copy link
 #12

Updated by livdywan 3 days ago

Indeed. There's uncovered bits visible on Codecov.

Actions
Copy link
 #13

Updated by gpathak 3 days ago

gpathak wrote in #note-9:

Attached code coverage generated html file.
It's just, I am unable to understand how to test subrouties calling _exit() at the end.
@okurz @mkittler Please review the attached code coverage. If it looks okay, I will then mark the Pull request ready for merging.

I couldn't find a way to catch _exit() in unit tests. I will try to find any existing test implementation.

Actions
Copy link

Also available in: Atom PDF