action #162503: AssetPack should fail if sass fails size:M - openQA Project (public) - openSUSE Project Management Tool

Custom queries

All 'new' issues w/o assignee, sorted by version/priority
All auto_review tickets
All auto_review+force_result tickets
openQA Infrastructure Project
openqa-review - Closed tickets last updated by openqa-review, last 30 days
QA roadmap long-term
QA SLE functional
QA SLE Functional - closed in last 14 days
QA SLE Functional - High, need to be refined
QA SLE Functional - over cycle time median
QA SLE u
QA SLE y
QA tools (tag not necessary in openQA and subprojects)
QA tools tag (tag not necessary in openQA and subprojects; excluding tickets in "Ready" version as they are already on the backlog)
QAC - Backlog
QE tools team - backlog (dev)
QE tools team - backlog (ready issues)
QE tools team - backlog SLA high
QE tools team - backlog SLA immediate
QE tools team - backlog SLA no immediate/urgent in feedback/blocked
QE tools team - backlog SLA normal
QE tools team - backlog SLA urgent
QE tools team - backlog SLO high
QE tools team - backlog SLO normal
QE tools team - backlog SLO urgent
QE tools team - backlog, high-level view (epics and higher)
QE tools team - backlog, non-reactive work, needs parent
QE tools team - backlog, top-level view (all sagas)
QE tools team - closed within last 14 days
QE tools team - closed within last 60 days
QE tools team - closed yesterday
QE Tools Team - Collaborative Session
QE tools team - due date forecast
QE Tools team - due soon
QE tools team - exceeding due-date
QE tools team - infrastructure backlog
QE tools team - next - sorted by update time
QE tools team - next issues
QE tools team - non-estimated (unblocked) issues (dev)
QE tools team - non-estimated (unblocked) issues (infra)
QE tools team - ready issues - Workable
QE tools team - ready, not assigned/blocked/low
QE tools team - SLO high forecast
QE tools team - update forecast
QE tools team - updated by priority
QE tools team - what members of the team are working on - Feedback (not-low)
QE Tools Team Backlog By Assignee
Tools Team Retrospective
Tools Team Retrospective (not estimated or assigned)

Actions

Copy link

action #162503

open

coordination #154768: [saga][epic][ux] State-of-art user experience for openQA

coordination #157510: [epic] Up-to-date JavaScript stack

AssetPack should fail if sass fails size:M

Added by okurz 6 months ago. Updated 1 day ago.

Status:

Feedback

Priority:

Low

Assignee:

jbaier_cz

Category:

Feature requests

Target version:

Ready

Start date:

Due date:

% Done:

Estimated time:

Description

Acceptance criteria¶

AC1: openQA package builds fail if the assets can not be fully prepared, e.g. AssetPack should fail on sass execution errors

Suggestions¶

AssetPack is ignoring relevant errors. Can we change that? - Yes
Start with https://github.com/mojolicious/mojo-assetpack/blob/main/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L67 . looks like the return value is not evaluated?
Add a test which simulates a failing sass and ensure that the code catches the result
You need to handle kraih being nit-picky
Open a PR upstream in AssetPack (and don't forget tests)

Related issues 1 (0 open — 1 closed)

Copied from openQA Project (public) - action #162311: [sporadic] openqa-in-openqa-test fails in openqa_webui due to CSS files not successfully generated size:M

Resolved

tinita

2024-06-14

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by okurz 6 months ago

Copied from action #162311: [sporadic] openqa-in-openqa-test fails in openqa_webui due to CSS files not successfully generated size:M added

Actions

Copy link

Updated by okurz 6 months ago

Parent task set to #157510

Actions

Copy link

Updated by tinita 6 months ago

Description updated (diff)

AssetPack's CI was fixed in the meantime.

Actions

Copy link

Updated by okurz 5 months ago

Target version changed from Tools - Next to Ready

Actions

Copy link

Updated by mkittler 5 months ago

Subject changed from AssetPack should fail if sass fails to AssetPack should fail if sass fails size:M
Description updated (diff)
Status changed from New to Workable

Actions

Copy link

Updated by okurz 5 months ago

Target version changed from Ready to Tools - Next

Actions

Copy link

Updated by okurz 4 months ago

Target version changed from Tools - Next to Ready

Actions

Copy link

Updated by jbaier_cz 4 months ago

Status changed from Workable to In Progress
Assignee set to jbaier_cz

Actions

Copy link

Updated by jbaier_cz 4 months ago

Pull requested created: https://github.com/mojolicious/mojo-assetpack/pull/154

Actions

Copy link

#10

Updated by openqa_review 4 months ago

Due date set to 2024-08-24

Setting due date based on mean cycle time of SUSE QE Tools

Actions

Copy link

#11

Updated by jbaier_cz 4 months ago

Status changed from In Progress to Feedback

Let's put it in feedback until I get something from the upstream.

Actions

Copy link

#12

Updated by okurz 4 months ago

Due date deleted (~~2024-08-24~~)
Status changed from Feedback to Blocked
Priority changed from Normal to Low

we can actually block on https://github.com/mojolicious/mojo-assetpack/pull/154 and this can take some time which is not critical for us so I set to "low" and removed the due date.

Actions

Copy link

#13