Actions
action #162503
opencoordination #154768: [saga][ux] State-of-art user experience for openQA
coordination #157510: [epic] Up-to-date JavaScript stack
AssetPack should fail if sass fails size:M
Start date:
Due date:
% Done:
0%
Estimated time:
Description
Acceptance criteria¶
- AC1: openQA package builds fail if the assets can not be fully prepared, e.g. AssetPack should fail on sass execution errors
Suggestions¶
- AssetPack is ignoring relevant errors. Can we change that? - Yes
- Start with https://github.com/mojolicious/mojo-assetpack/blob/main/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L67 . looks like the return value is not evaluated?
- Add a test which simulates a failing sass and ensure that the code catches the result
- You need to handle kraih being nit-picky
- Open a PR upstream in AssetPack (and don't forget tests)
Actions