Project

General

Profile

action #162503

Updated by mkittler 5 months ago

## Acceptance criteria 
 * **AC1:** openQA package builds fail if the assets can not be fully prepared, e.g. AssetPack assetpack should fail on sass execution errors 

 ## Suggestions 
 * AssetPack is ignoring relevant errors. Can we change that? - Yes 
 * Start with https://github.com/mojolicious/mojo-assetpack/blob/main/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L67 . looks like the return value is not evaluated? 
 * Add a test which simulates a failing sass and ensure that the code catches the result 
 * You need to handle kraih being nit-picky 
 * Open a PR upstream in AssetPack (and don't forget tests)

Back