Actions
action #162503
opencoordination #154768: [saga][epic][ux] State-of-art user experience for openQA
coordination #157510: [epic] Up-to-date JavaScript stack
AssetPack should fail if sass fails size:M
Description
Acceptance criteria¶
- AC1: openQA package builds fail if the assets can not be fully prepared, e.g. AssetPack should fail on sass execution errors
Suggestions¶
- AssetPack is ignoring relevant errors. Can we change that? - Yes
- Start with https://github.com/mojolicious/mojo-assetpack/blob/main/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L67 . looks like the return value is not evaluated?
- Add a test which simulates a failing sass and ensure that the code catches the result
- You need to handle kraih being nit-picky
- Open a PR upstream in AssetPack (and don't forget tests)
Updated by okurz 3 months ago
- Copied from action #162311: [sporadic] openqa-in-openqa-test fails in openqa_webui due to CSS files not successfully generated size:M added
Updated by okurz about 1 month ago
- Target version changed from Tools - Next to Ready
Updated by jbaier_cz about 1 month ago
- Status changed from Workable to In Progress
- Assignee set to jbaier_cz
Updated by jbaier_cz about 1 month ago
Pull requested created: https://github.com/mojolicious/mojo-assetpack/pull/154
Updated by openqa_review about 1 month ago
- Due date set to 2024-08-24
Setting due date based on mean cycle time of SUSE QE Tools
Updated by jbaier_cz about 1 month ago
- Status changed from In Progress to Feedback
Let's put it in feedback until I get something from the upstream.
Updated by okurz about 1 month ago
- Due date deleted (
2024-08-24) - Status changed from Feedback to Blocked
- Priority changed from Normal to Low
we can actually block on https://github.com/mojolicious/mojo-assetpack/pull/154 and this can take some time which is not critical for us so I set to "low" and removed the due date.
Actions