action #162503
opencoordination #154768: [saga][epic][ux] State-of-art user experience for openQA
coordination #157510: [epic] Up-to-date JavaScript stack
AssetPack should fail if sass fails size:M
Description
Acceptance criteria¶
- AC1: openQA package builds fail if the assets can not be fully prepared, e.g. AssetPack should fail on sass execution errors
Suggestions¶
- AssetPack is ignoring relevant errors. Can we change that? - Yes
- Start with https://github.com/mojolicious/mojo-assetpack/blob/main/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L67 . looks like the return value is not evaluated?
- Add a test which simulates a failing sass and ensure that the code catches the result
- You need to handle kraih being nit-picky
- Open a PR upstream in AssetPack (and don't forget tests)
Updated by okurz 6 months ago
- Copied from action #162311: [sporadic] openqa-in-openqa-test fails in openqa_webui due to CSS files not successfully generated size:M added
Updated by jbaier_cz 4 months ago
Pull requested created: https://github.com/mojolicious/mojo-assetpack/pull/154
Updated by openqa_review 4 months ago
- Due date set to 2024-08-24
Setting due date based on mean cycle time of SUSE QE Tools
Updated by okurz 4 months ago
- Due date deleted (
2024-08-24) - Status changed from Feedback to Blocked
- Priority changed from Normal to Low
we can actually block on https://github.com/mojolicious/mojo-assetpack/pull/154 and this can take some time which is not critical for us so I set to "low" and removed the due date.
Updated by okurz 13 days ago
- Status changed from Blocked to Feedback
https://github.com/mojolicious/mojo-assetpack/pull/154 merged. does this suffice to resolve?
Updated by jbaier_cz 7 days ago
- Status changed from Workable to Blocked
The new version is not yet in use, if I understood correctly the update in TW needs a manual step: https://build.opensuse.org/request/show/1230597
Updated by tinita 7 days ago ยท Edited
As in the description of https://build.opensuse.org/project/show/devel:languages:perl:autoupdate the updated packages are created automatically, normally, and then I have to make submit requests manually.
Due to reasons the update stopped running 2 months ago. I triggered it now: https://github.com/openSUSE/autoupdate-perl/actions/runs/12300277071/job/34328046537
Let's see, I might have to trigger it multiple times since it only updates 20 packages in one run.
Updates will land here: https://build.opensuse.org/project/show/devel:languages:perl:autoupdate
I declined https://build.opensuse.org/request/show/1230597 because we want version normalization.
Updated by jbaier_cz 3 days ago
We should be good after https://build.opensuse.org/request/show/1231542 is accepted
Updated by okurz 1 day ago
https://build.opensuse.org/request/show/1231542 is accepted