QA

PRs: https://github.com/openSUSE/qem-bot/pull/171, https://github.com/openSUSE/qem-dashboard/pull/844

Could this caused the regression seen in https://gitlab.suse.de/qa-maintenance/bot-ng/-/jobs/2327744 ?

  File "./qem-bot/bot-ng.py", line 7, in <module>
    main()
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/main.py", line 32, in main
    sys.exit(cfg.func(cfg))
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/args.py", line 34, in do_aggregate_schedule
    bot = OpenQABot(args)
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/openqabot.py", line 24, in __init__
    self.incidents = get_incidents(self.token)
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/loader/qem.py", line 41, in get_incidents
    xs.append(Incident(i))
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/types/incident.py", line 23, in __init__
    self.priority = incident["priority"]
KeyError: 'priority'

mkittler wrote in #note-11:

Handles in the other ticket.

So all PRs are prepared. If they are merged and deployed I'll have a look at whether it actually works. (Maybe there are still some bits missing.)

Does this change include the display of the priority from SMELT ?

From my experience it would be helpful to have this because it gives indications on if some updates have (almost) the same priority or if there are large gaps in the priority list.

I'm not familiar with SMELT myself. Considering you're underlining "display" I assume there are multiple priorities. It is about the priority displayed on the top-right corner of pages like https://smelt.suse.de/incident/23314. In that example that would be 379 at the time I'm writing this comment. I'm not aware of any other priorities an incident might have.

If you are just referring to the word "important" left next to the figure: I think this is called "Rating". It will not be displayed anywhere at this point. I suppose it is computed from the prio. This computation could be done on the dashboard as well and shown somewhere on the "Blocked" page. I suppose that'll be another feature request. If we do this we need to make sure that SMELT and the dashboard agree on how the rating is computed. The SMELT API could also expose the computed value which the dashboard would just show as-is. This would ease keeping things in-line with each other but unless the SMELT API would also expose the background color the dashboard could not show the background color accordingly.

mkittler wrote in #note-13:

I'm not familiar with SMELT myself. Considering you're underlining "display" I assume there are multiple priorities. It is about the priority displayed on the top-right corner of pages like https://smelt.suse.de/incident/23314. In that example that would be 379 at the time I'm writing this comment. I'm not aware of any other priorities an incident might have.

Yes, that is exactly the priority value I mean.

It is displayed as well in the queue display of updates to be tested:
https://smelt.suse.de/overview/#testing (Column "Prio")

If you are just referring to the word "important" left next to the figure: I think this is called "Rating". It will not be displayed anywhere at this point. I suppose it is computed from the prio. This computation could be done on the dashboard as well and shown somewhere on the "Blocked" page. I suppose that'll be another feature request. If we do this we need to make sure that SMELT and the dashboard agree on how the rating is computed. The SMELT API could also expose the computed value which the dashboard would just show as-is. This would ease keeping things in-line with each other but unless the SMELT API would also expose the background color the dashboard could not show the background color accordingly.

The Rating should not be part of this implementation. Currently, we don't plan to have it displayed on https://dashboard.qam.suse.de/blocked

Waiting for second approval on https://github.com/openSUSE/qem-dashboard/pull/844