QA (public) » openQA Project (public)

I executed a rollback of osd-deployment in GitLab, for now the group display seems to work again (I don't know what caused it at this point)

I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding

okurz wrote:

I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding

Ack, found it in the logs now:

08:16:03 openqa openqa[6916]: [error] [uSiTFOk5fWlH] Global symbol "$job" requires explicit package name (did you forget to declare "my $job"?) at template branding/openqa.suse.de/commenting_tools.html.ep line 1.
08:16:03 openqa openqa[6916]: Context:
08:16:03 openqa openqa[6916]:   1: % if (!$group_comment && !$job->is_ok) {
08:16:03 openqa openqa[6916]:   2:     <a class="help_popover fa fa-unlink" title="Add marker so the specified maintenance incident will be approved despite this job"
08:16:03 openqa openqa[6916]:   3:        role="button" data-template="@review:acceptable_for:incident_<incident_id>:<reason>" onclick="insertTemplate(this)"></a>
08:16:03 openqa openqa[6916]:   4:     <br>
08:16:03 openqa openqa[6916]:   5: % }