action #119467
closed"Internal server error" on opening any job group front page at OSD
Description
Observation¶
Build specific pages etc work, but job group front page like https://openqa.suse.de/group_overview/268 does not.
Acceptance criteria¶
- AC1: No obvious related regression on OSD
- AC2: Test coverage for the branding button code exists for both the job comments as well as job group comments
Files
Updated by okurz about 2 years ago
- Category set to Regressions/Crashes
- Priority changed from Normal to Immediate
- Target version set to Ready
Updated by okurz about 2 years ago
- Related to action #119473: [openqa][group overview] Group view is not available added
Updated by livdywan about 2 years ago
I executed a rollback of osd-deployment in GitLab, for now the group display seems to work again (I don't know what caused it at this point)
Updated by tjyrinki_suse about 2 years ago
- Status changed from New to In Progress
Working now, thank you!
Updated by tjyrinki_suse about 2 years ago
- Status changed from In Progress to New
Updated by okurz about 2 years ago
I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding
Updated by livdywan about 2 years ago
okurz wrote:
I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding
Ack, found it in the logs now:
08:16:03 openqa openqa[6916]: [error] [uSiTFOk5fWlH] Global symbol "$job" requires explicit package name (did you forget to declare "my $job"?) at template branding/openqa.suse.de/commenting_tools.html.ep line 1.
08:16:03 openqa openqa[6916]: Context:
08:16:03 openqa openqa[6916]: 1: % if (!$group_comment && !$job->is_ok) {
08:16:03 openqa openqa[6916]: 2: <a class="help_popover fa fa-unlink" title="Add marker so the specified maintenance incident will be approved despite this job"
08:16:03 openqa openqa[6916]: 3: role="button" data-template="@review:acceptable_for:incident_<incident_id>:<reason>" onclick="insertTemplate(this)"></a>
08:16:03 openqa openqa[6916]: 4: <br>
08:16:03 openqa openqa[6916]: 5: % }
Updated by livdywan about 2 years ago
- Status changed from New to Feedback
- Assignee set to livdywan
Revert merged https://github.com/os-autoinst/openQA/pull/4874
Updated by okurz about 2 years ago
- Description updated (diff)
- Status changed from Feedback to Blocked
- Priority changed from Immediate to Normal
with the revert merged we can reduce the urgency. I suggest we block on #107923 and recheck afterwards.
Updated by okurz about 2 years ago
- Status changed from Blocked to Resolved
rest is covered in #107923#note-30