Project

General

Profile

action #119467

"Internal server error" on opening any job group front page at OSD

Added by tjyrinki_suse 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

Build specific pages etc work, but job group front page like https://openqa.suse.de/group_overview/268 does not.

Acceptance criteria

  • AC1: No obvious related regression on OSD
  • AC2: Test coverage for the branding button code exists for both the job comments as well as job group comments
servererror.png (42 KB) servererror.png tjyrinki_suse, 2022-10-27 05:59
13999

Related issues

Related to openQA Project - action #119473: [openqa][group overview] Group view is not available Rejected2022-10-27

Related to QA - action #107923: qem-bot: Ignore not-ok openQA jobs for specific incident based on openQA job comment size:MWorkable

History

#1 Updated by okurz 3 months ago

  • Category set to Concrete Bugs
  • Priority changed from Normal to Immediate
  • Target version set to Ready

#2 Updated by okurz 3 months ago

  • Related to action #119473: [openqa][group overview] Group view is not available added

#3 Updated by cdywan 3 months ago

I executed a rollback of osd-deployment in GitLab, for now the group display seems to work again (I don't know what caused it at this point)

#4 Updated by tjyrinki_suse 3 months ago

  • Status changed from New to In Progress

Working now, thank you!

#5 Updated by tjyrinki_suse 3 months ago

  • Status changed from In Progress to New

#6 Updated by okurz 3 months ago

I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding

#7 Updated by cdywan 3 months ago

okurz wrote:

I suspect https://github.com/os-autoinst/openQA/pull/4867 is causing an issue as the comment edit window is also used on the group overview page but was only tested on jobs together with branding

Ack, found it in the logs now:

08:16:03 openqa openqa[6916]: [error] [uSiTFOk5fWlH] Global symbol "$job" requires explicit package name (did you forget to declare "my $job"?) at template branding/openqa.suse.de/commenting_tools.html.ep line 1.
08:16:03 openqa openqa[6916]: Context:
08:16:03 openqa openqa[6916]:   1: % if (!$group_comment && !$job->is_ok) {
08:16:03 openqa openqa[6916]:   2:     <a class="help_popover fa fa-unlink" title="Add marker so the specified maintenance incident will be approved despite this job"
08:16:03 openqa openqa[6916]:   3:        role="button" data-template="@review:acceptable_for:incident_<incident_id>:<reason>" onclick="insertTemplate(this)"></a>
08:16:03 openqa openqa[6916]:   4:     <br>
08:16:03 openqa openqa[6916]:   5: % }

#8 Updated by cdywan 3 months ago

  • Status changed from New to Feedback
  • Assignee set to cdywan

#9 Updated by okurz 3 months ago

  • Related to action #107923: qem-bot: Ignore not-ok openQA jobs for specific incident based on openQA job comment size:M added

#10 Updated by okurz 3 months ago

  • Description updated (diff)
  • Status changed from Feedback to Blocked
  • Priority changed from Immediate to Normal

with the revert merged we can reduce the urgency. I suggest we block on #107923 and recheck afterwards.

#11 Updated by okurz 3 months ago

  • Status changed from Blocked to Resolved

rest is covered in #107923#note-30

Also available in: Atom PDF