Project

General

Profile

action #110518

coordination #102915: [saga][epic] Automated classification of failures

QA - coordination #94105: [epic] Use feedback from openqa-investigate to automatically inform on github pull requests, open tickets, weed out automatically failed tests

Call job_done_hooks if requested by test setting (not only openQA config as done so far) size:M

Added by okurz about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2021-09-18
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

User story

Commonly we want to call job_done_hooks only on failed or incomplete jobs. For some cases, e.g. openqa-investigate, it makes sense to call job_done_hooks on passed jobs. To not overwhelm an openQA instance with too much overhead calling job_done_hooks on all jobs we could ask openQA with a test setting to only do this for specific jobs

Acceptance criteria

  • AC1: If an openQA job has a specific test setting, e.g. _TRIGGER_JOB_DONE_HOOK=1, then the job done hook is called regardless of the openQA config
  • AC2: If an openQA job does not have any special test setting but fails and openQA is configured to call the job_done_hook on failed jobs the job_done_hook is still called

Suggestions


Related issues

Related to openQA Project - action #95783: Provide support for multi-machine scenarios handled by openqa-investigate size:MWorkable

Related to openQA Project - action #111314: _SECRET_ variables are exposed in vars.json when the job is not completed.Workable2022-05-19

Copied from openQA Project - action #98862: Comment about intermittent/sporadic test issues on original job if openqa-investigate retry job passesNew2021-09-18

Copied to openQA Project - action #110530: Do NOT call job_done_hooks if requested by test settingResolved2021-09-18

History

#1 Updated by okurz about 2 months ago

  • Copied from action #98862: Comment about intermittent/sporadic test issues on original job if openqa-investigate retry job passes added

#2 Updated by okurz about 2 months ago

  • Related to action #95783: Provide support for multi-machine scenarios handled by openqa-investigate size:M added

#3 Updated by okurz about 2 months ago

  • Description updated (diff)

#4 Updated by okurz about 2 months ago

  • Copied to action #110530: Do NOT call job_done_hooks if requested by test setting added

#5 Updated by okurz about 1 month ago

We currently have the configuration for the actual job done hooks to be called within the config variable itself which is mostly duplicated already anyway. So we could

  1. Simply ask the user to specify the complete configuration string in the test variable
  2. Or we just reference another hook by name that we call itself, e.g. _TRIGGER_JOB_DONE_HOOK=failed meaning to trigger the hook defined in the config key "job_done_hook"
  3. Or we define a generic config string and only enable/disable them for each result and enable in the test with the boolean test setting _TRIGGER_JOB_DONE_HOOK=1. Example config:
job_done_hook = env enable_force_result=true from_email=…@suse.de notification_address=…@suse.slack.com host=openqa.suse.de exclude_group_regex='.*(Development|Public Cloud|Released|Others|Kernel|Virtualization).*' grep_timeout=60 nice ionice -c idle /opt/os-autoinst-scripts/openqa-label-known-issues-and-investigate-hook
# just "1" to enable hooks based on the generic
job_done_hook_enable_failed = 1
job_done_hook_enable_incomplete = 1
# still a custom hook for timeout_exceeded, automatically enabled if defined
job_done_hook_timeout_exceeded = env … /opt/os-autoinst-scripts/openqa-handle-timeout-hook

#6 Updated by cdywan about 1 month ago

  • Related to action #111314: _SECRET_ variables are exposed in vars.json when the job is not completed. added

#7 Updated by mkittler about 1 month ago

  • Assignee set to mkittler

#8 Updated by mkittler about 1 month ago

  • Status changed from Workable to In Progress

#9 Updated by openqa_review about 1 month ago

  • Due date set to 2022-06-07

Setting due date based on mean cycle time of SUSE QE Tools

#10 Updated by mkittler about 1 month ago

  • Status changed from In Progress to Feedback

#11 Updated by mkittler about 1 month ago

  • Due date deleted (2022-06-07)
  • Status changed from Feedback to Resolved

The PR has been merged

Also available in: Atom PDF