https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842021-10-01T12:24:33ZopenSUSE Project Management ToolopenQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4515452021-10-01T12:24:33Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Already started with that in <a href="https://github.com/os-autoinst/os-autoinst/pull/1773" class="external">https://github.com/os-autoinst/os-autoinst/pull/1773</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4515542021-10-01T12:40:41Zokurzokurz@suse.com
<ul></ul><p>I had started already here but as I recurringly fail to finish I am splitting this up in multiple PRs for easier testing and planned merges one at a time:</p>
<ul>
<li><em>DONE</em> <a href="https://github.com/os-autoinst/os-autoinst/pull/1793" class="external">https://github.com/os-autoinst/os-autoinst/pull/1793</a> - t/data, merged</li>
<li><em>DONE</em> <a href="https://github.com/os-autoinst/os-autoinst/pull/1792" class="external">https://github.com/os-autoinst/os-autoinst/pull/1792</a> - t, merged</li>
<li><em>DONE</em> <a href="https://github.com/os-autoinst/os-autoinst/pull/1794" class="external">https://github.com/os-autoinst/os-autoinst/pull/1794</a> - tools, merged</li>
<li><em>DONE</em> <a href="https://github.com/os-autoinst/os-autoinst/pull/1791" class="external">https://github.com/os-autoinst/os-autoinst/pull/1791</a> - OpenQA/, merged</li>
<li><a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> - consoles, multiple errors, needs work but should be merged later anyway</li>
<li><a href="https://github.com/os-autoinst/os-autoinst/pull/1790" class="external">https://github.com/os-autoinst/os-autoinst/pull/1790</a> - backend, same as above</li>
</ul>
<p>let's see which ones succeed. Based on criticality we can decide which ones to merge first. I suggest to first do low-risk ones like tools and t/, later backends and consoles</p>
<p>EDIT: Updated current status of PRs</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4532072021-10-07T15:16:36Zokurzokurz@suse.com
<ul></ul><p>3 done, 3 to go</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4552912021-10-14T07:14:55Zokurzokurz@suse.com
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-4 status-12 priority-3 priority-lowest" href="/issues/100967">action #100967</a>: Use more perl signatures - openQA size:M</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4562762021-10-18T16:53:12Zokurzokurz@suse.com
<ul></ul><p>additional PR for myjsonrpc only: <a href="https://github.com/os-autoinst/os-autoinst/pull/1827" class="external">https://github.com/os-autoinst/os-autoinst/pull/1827</a> - merged</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4621132021-11-09T09:40:57Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-3 priority-lowest closed behind-schedule" href="/issues/102146">action #102146</a>: Deprecate os-autoinst backend::pvm</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4643182021-11-15T11:08:25Zokurzokurz@suse.com
<ul></ul><p>I now merged <a href="https://github.com/os-autoinst/os-autoinst/pull/1790" class="external">https://github.com/os-autoinst/os-autoinst/pull/1790</a> "use signatures in os-autoinst backend" as it was ready and has approval. I will have alert duty this week so hopefully I would see any fallout :)</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4662742021-11-19T11:19:01Zokurzokurz@suse.com
<ul></ul><p>There was no feedback on the last merged pull request so I assume we are good and can continue with the next, i.e. "consoles"</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4697732021-12-01T14:02:22Zlivdywanliv.dywan@suse.com
<ul></ul><p>okurz wrote:</p>
<blockquote>
<p>There was no feedback on the last merged pull request so I assume we are good and can continue with the next, i.e. "consoles"</p>
</blockquote>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1868" class="external">https://github.com/os-autoinst/os-autoinst/pull/1868</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4698092021-12-01T20:30:38Zokurzokurz@suse.com
<ul></ul><p>I am playing it safe and doing the first part of consoles with <a href="https://github.com/os-autoinst/os-autoinst/pull/1868" class="external">https://github.com/os-autoinst/os-autoinst/pull/1868</a> (merged). <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> includes the second part. I realized that a good additional test is to execute the openQA full stack test while I have my signatures changes in os-autoinst checked out locally. Seems like maybe the os-autoinst tests do not cover the complete interface for the interactive mode and such so I will test my changes with openQA first.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4718042021-12-09T12:39:49Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>I will wait for some more critical os-autoinst related changes before continuing, e.g. waiting for <a class="issue tracker-4 status-3 priority-6 priority-high2 closed" title="action: [sporadic] os-autoinst: 13-osutils.t:167 Failed test 'Exit code appear in log' in GHA size:M (Resolved)" href="https://progress.opensuse.org/issues/103422">#103422</a> and <a class="issue tracker-4 status-3 priority-6 priority-high2 closed" title="action: test failure: os-autoinst: 29-backend-driver.t:31 Failed test 'exit logged' (Resolved)" href="https://progress.opensuse.org/issues/103611">#103611</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4792932022-01-11T12:10:46Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>In Progress</i></li></ul><p>prepared <a href="https://github.com/os-autoinst/os-autoinst/pull/1899" class="external">https://github.com/os-autoinst/os-autoinst/pull/1899</a> for parts of the consoles and merged. Continuing with consoles in <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4807662022-01-18T07:20:10Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-6 priority-high2 closed" href="/issues/104986">action #104986</a>: tests incomplete with: auto_review:"backend died: Too many arguments for subroutine.*consoles::vnc_base::get_last_mouse_set":retry</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4819362022-01-20T09:46:56Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-12 priority-3 priority-lowest" href="/issues/104520">action #104520</a>: Move svirt extract_asset code from os-autoinst-distri-opensuse to os-autoinst/backend/svirt.pm size:M auto_review:"unable to extract assets: Can't call method.+name.+on an undefined value":retry</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4836802022-01-25T14:59:13Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>The PR <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> is basically ready but so far nobody dared to merge it due to the lower statement code coverage of consoles::VNC. One simple related change which actually also touches consoles::VNC is <a href="https://github.com/os-autoinst/os-autoinst/pull/1934" class="external">https://github.com/os-autoinst/os-autoinst/pull/1934</a> about the "ikvm" backend. Currently <a href="https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm" class="external">https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm</a> reports 57%. I rebased <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> and will see what this will end up with as coverage. Previously the patch coverage in the PR was reported as 67%.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4897492022-02-10T18:44:55Zokurzokurz@suse.com
<ul></ul><p>surprisngly cdywan merged <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> . I assume they missed our discussions and plans. Regardless, I checked jobs on <a href="https://openqa.opensuse.org/tests" class="external">https://openqa.opensuse.org/tests</a> and found no related failures so I guess we are good with that change. I can now continue with <a href="https://github.com/os-autoinst/os-autoinst/pull/1773" class="external">https://github.com/os-autoinst/os-autoinst/pull/1773</a> but that's still a rather big PR so maybe split out more files.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4897642022-02-10T20:22:13Zlivdywanliv.dywan@suse.com
<ul></ul><p>okurz wrote:</p>
<blockquote>
<p>surprisngly cdywan merged <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> . I assume they missed our discussions and plans. Regardless, I checked jobs on <a href="https://openqa.opensuse.org/tests" class="external">https://openqa.opensuse.org/tests</a> and found no related failures so I guess we are good with that change.</p>
</blockquote>
<p>2 approvals, 2 other reviewers, no objections after having brought up concerns with coverage. I sanity-checked also. Typically we merge in such cases. If you clearly didn't want it merged I suggest a blocking review, draft or <code>not-ready</code> label for the future.</p>
<blockquote>
<p>I can now continue with <a href="https://github.com/os-autoinst/os-autoinst/pull/1773" class="external">https://github.com/os-autoinst/os-autoinst/pull/1773</a> but that's still a rather big PR so maybe split out more files.</p>
</blockquote>
<p>How about consoles+backends and api(mmapi/bmwqemu/distribution) or something along those lines?</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4897722022-02-10T21:35:44Zokurzokurz@suse.com
<ul></ul><p>cdywan wrote:</p>
<blockquote>
<p>okurz wrote:</p>
<blockquote>
<p>surprisngly cdywan merged <a href="https://github.com/os-autoinst/os-autoinst/pull/1789" class="external">https://github.com/os-autoinst/os-autoinst/pull/1789</a> . I assume they missed our discussions and plans. Regardless, I checked jobs on <a href="https://openqa.opensuse.org/tests" class="external">https://openqa.opensuse.org/tests</a> and found no related failures so I guess we are good with that change.</p>
</blockquote>
<p>2 approvals, 2 other reviewers, no objections after having brought up concerns with coverage. I sanity-checked also. Typically we merge in such cases. If you clearly didn't want it merged I suggest a blocking review, draft or <code>not-ready</code> label for the future.</p>
</blockquote>
<p>sure, not your fault at all but mine and it seems all turned out well.</p>
<blockquote>
<blockquote>
<p>I can now continue with <a href="https://github.com/os-autoinst/os-autoinst/pull/1773" class="external">https://github.com/os-autoinst/os-autoinst/pull/1773</a> but that's still a rather big PR so maybe split out more files.</p>
</blockquote>
<p>How about consoles+backends and api(mmapi/bmwqemu/distribution) or something along those lines?</p>
</blockquote>
<p>yes, that's what I am thinking.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=4902132022-02-11T17:05:30Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-4 priority-default closed" href="/issues/106654">action #106654</a>: [ipmi][openqa][vnc] Massive test run failures with 'IO::Socket::INET: connect: Connection refused' due to "Use of uninitialized value.*connect_timeout in addition.*consoles/VNC.pm line 13.*":retry</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5009062022-03-15T11:51:46Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-4 priority-default closed" href="/issues/108323">action #108323</a>: Subroutine consoles::sshVirtsh::has redefined at .../Class/Accessor.pm</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5086112022-04-06T20:06:32Zokurzokurz@suse.com
<ul></ul><p>one more step: <a href="https://github.com/os-autoinst/os-autoinst/pull/2006" class="external">https://github.com/os-autoinst/os-autoinst/pull/2006</a> merged</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5150982022-05-02T13:24:17Zokurzokurz@suse.com
<ul><li><strong>Subject</strong> changed from <i>Use more perl signatures - os-autoinst</i> to <i>Use more perl signatures - os-autoinst size:M</i></li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5158152022-05-04T10:38:58Zokurzokurz@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/2046" class="external">https://github.com/os-autoinst/os-autoinst/pull/2046</a> for commands.pm . Should wait a day or two for feedback before continuing.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5172702022-05-09T13:51:01Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>In Progress</i></li></ul><p>PR merged, no problems observed. Continuing with <a href="https://github.com/os-autoinst/os-autoinst/pull/1773" class="external">https://github.com/os-autoinst/os-autoinst/pull/1773</a> , now merged as well. Continuing with more files which have received non-signature changes since then and some places which I might have missed and testapi.pm itself as well.</p>
<p>Continuing in <a href="https://mysuse.sharepoint.com/:v:/s/HowWeWork/ERL9nT8YLmNOnfjj5G53MfUBE2rFh1BeYA7kNTxhZpC4UQ?e=iYvr7b" class="external">https://mysuse.sharepoint.com/:v:/s/HowWeWork/ERL9nT8YLmNOnfjj5G53MfUBE2rFh1BeYA7kNTxhZpC4UQ?e=iYvr7b</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5184852022-05-12T06:56:38Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-6 priority-high2 closed" href="/issues/110983">action #110983</a>: Wrong signatures auto_review:"Too.*arguments for subroutine":retry</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5191862022-05-13T09:31:39Zokurzokurz@suse.com
<ul></ul><p>Brought up in weekly 2022-05-13. I was making a stupid mistake on trying to just add <code>-signatures</code> in one commit and see how that goes but of course that stumbles already over the prototypes used. So I should definitely use both together.</p>
<p>I am welcoming everybody to review <a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> and help me with some suggestions.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5195432022-05-16T08:28:57Zokurzokurz@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/2060" class="external">https://github.com/os-autoinst/os-autoinst/pull/2060</a> merged including parts of the above including a syntax check to ensure we have signatures in all perl files, except testapi.pm so far.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5204282022-05-18T18:52:29Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> ready</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5217112022-05-20T18:06:57Zokurzokurz@suse.com
<ul></ul><p>As this PR still turns out to be too big to be easily review I am splitting out yet another PR:</p>
<ul>
<li><a href="https://github.com/os-autoinst/os-autoinst/pull/2069" class="external">https://github.com/os-autoinst/os-autoinst/pull/2069</a></li>
</ul>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5242672022-05-31T08:04:14Zokurzokurz@suse.com
<ul></ul><p>To prevent breakage in os-autoinst-distri-opensuse I prepared three PRs:</p>
<ul>
<li><a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14996" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14996</a></li>
<li><a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14997" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14997</a></li>
<li><a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14998" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14998</a></li>
</ul>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5273512022-06-09T14:10:59Zokurzokurz@suse.com
<ul></ul><p>All three merged. Now I created <a href="https://github.com/os-autoinst/os-autoinst/pull/2078" class="external">https://github.com/os-autoinst/os-autoinst/pull/2078</a> which should include only the testapi.pm changes that are covered by automatic tests.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5281402022-06-13T09:16:15Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-1 priority-3 priority-lowest" href="/issues/112319">action #112319</a>: Better and earlier checks of test code against "wrong API usage"</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5321962022-06-23T15:07:28Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Workable</i></li></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> . Haven't found anymore problems on openqaworker7. I suggest we continue with some unit tests in a mob programming session.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5388912022-07-20T08:24:52Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-3 priority-4 priority-default closed child parent" href="/issues/109740">coordination #109740</a>: [epic] Stable os-autoinst unit tests with good coverage</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5389302022-07-20T08:39:47Zlivdywanliv.dywan@suse.com
<ul></ul><p>okurz wrote:</p>
<blockquote>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> . Haven't found anymore problems on openqaworker7. I suggest we continue with some unit tests in a mob programming session.</p>
</blockquote>
<p><strong>testapi</strong> unit tests, as opposed to <a class="issue tracker-4 status-3 priority-3 priority-lowest closed child" title="action: [easy][beginner] Increase code coverage of os-autoinst basetest.pm size:M (Resolved)" href="https://progress.opensuse.org/issues/94952">#94952</a> which covers basetest</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5735492022-11-11T06:57:07Zokurzokurz@suse.com
<ul><li><strong>Target version</strong> changed from <i>Ready</i> to <i>future</i></li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5958282023-01-21T15:09:33Zokurzokurz@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/2252" class="external">https://github.com/os-autoinst/os-autoinst/pull/2252</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=5978942023-01-31T13:10:49Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>Feedback</i></li><li><strong>Target version</strong> changed from <i>future</i> to <i>Ready</i></li></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> rebased on top of <del><a href="https://github.com/os-autoinst/os-autoinst/pull/2252" class="external">https://github.com/os-autoinst/os-autoinst/pull/2252</a></del> and <a href="https://github.com/os-autoinst/os-autoinst/pull/2256" class="external">https://github.com/os-autoinst/os-autoinst/pull/2256</a> with all CI checks passed, i.e. the changed lines are fully covered in tests (not the complete functions but only the signature relevant lines). So finally the complete PR should be ready including enforcement of using signatures in all perl files in this project.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=6018112023-02-14T14:27:55Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> set to <i>2023-03-03</i></li></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/1696" class="external">https://github.com/os-autoinst/os-autoinst/pull/1696</a> and <a href="https://github.com/os-autoinst/os-autoinst/pull/2256" class="external">https://github.com/os-autoinst/os-autoinst/pull/2256</a> merged as well. If there are no corresponding regressions within the next days we can resolve.</p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=6022342023-02-15T08:53:01Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-6 priority-high2 closed" href="/issues/124538">action #124538</a>: generation of png from sound files creates a backtrace auto_review:"sh:.*snd2png.*HASH":retry</i> added</li></ul> openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=6022462023-02-15T09:01:15Zlivdywanliv.dywan@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/2261" class="external">https://github.com/os-autoinst/os-autoinst/pull/2261</a></p>
openQA Project - action #99663: Use more perl signatures - os-autoinst size:Mhttps://progress.opensuse.org/issues/99663?journal_id=6023782023-02-15T10:53:00Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> deleted (<del><i>2023-03-03</i></del>)</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>merged and deployed, <a href="https://openqa.opensuse.org/tests/3120074#step/firefox_audio/9" class="external">https://openqa.opensuse.org/tests/3120074#step/firefox_audio/9</a> fixed. With this I consider this ticket done.</p>