Project

General

Profile

Actions

action #94952

closed

coordination #109668: [saga][epic] Stable and updated non-qemu backends for SLE validation

coordination #109740: [epic] Stable os-autoinst unit tests with good coverage

[easy][beginner] Increase code coverage of os-autoinst basetest.pm size:M

Added by okurz over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Category:
Feature requests
Target version:
Start date:
2021-06-30
Due date:
% Done:

0%

Estimated time:

Description

Acceptance criteria

Suggestions

  • Take a look at the current coverage in https://codecov.io/gh/os-autoinst/os-autoinst/src/master/basetest.pm
  • Run the test locally and extend test coverage in t/17-basetest.t
  • Try to collect the code coverage locally (as documented in README) or just create pull requests and let codecov do the work
  • For example take "sub skip_if_not_running" and ensure to have code coverage for that

Further details

entrance level issue


Related issues 1 (0 open1 closed)

Copied to openQA Project - action #121357: [easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:MResolvedosukup

Actions
Actions #1

Updated by Anonymous over 3 years ago

  • Assignee set to Anonymous
Actions #2

Updated by okurz over 2 years ago

  • Tags set to easy, beginner, entrance level
  • Subject changed from Increase code coverage of os-autoinst basetest.pm to [easy][beginner] Increase code coverage of os-autoinst basetest.pm
  • Description updated (diff)
  • Parent task set to #109740
Actions #3

Updated by okurz over 2 years ago

  • Target version changed from future to Ready
Actions #4

Updated by okurz over 2 years ago

  • Subject changed from [easy][beginner] Increase code coverage of os-autoinst basetest.pm to [easy][beginner] Increase code coverage of os-autoinst basetest.pm size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #5

Updated by okurz about 2 years ago

  • Target version changed from Ready to future

We have to focus on other urgent tasks with reduced capacity so moving this out of backlog

Actions #6

Updated by okurz about 2 years ago

  • Target version changed from future to Ready
Actions #7

Updated by robert.richardson almost 2 years ago

  • Assignee set to robert.richardson
Actions #8

Updated by robert.richardson almost 2 years ago

  • Status changed from Workable to In Progress
Actions #10

Updated by robert.richardson almost 2 years ago

https://github.com/os-autoinst/os-autoinst/pull/2217
https://github.com/os-autoinst/os-autoinst/pull/2215 (WIP)

current state is ~97% coverage for basetest.pm,
remaining uncovered code:

1.
sub verify_sound_image()
Needs coverage for cases when no found needle is returned.
I tried passing candidates via the mock method but so far without success.
https://github.com/os-autoinst/os-autoinst/pull/2215/commits/84436b828c7d7e7c2e07a39998b9c3bcc5edb076 (attempt)

Actions #11

Updated by livdywan almost 2 years ago

  • Status changed from In Progress to Feedback

robert.richardson wrote:

https://github.com/os-autoinst/os-autoinst/pull/2215 (WIP)

The PR was merged.

Actions #12

Updated by robert.richardson almost 2 years ago

  • Status changed from Feedback to Resolved

https://github.com/os-autoinst/os-autoinst/pull/2226

marking this ticket as Resolved because AC states significant increase of code statement coverage and i'm at >99% coverage & have been working on this ticket for a while.

current basetest.pm coverage: 99.39%
see detailed (master) coverage here:
https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/basetest.pm

Newly covered code by individual PR:
https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2207 (+ 11.01%)
https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2210 (+ 1.83%)
https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2215 (+ 3.07%)
https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2226 (+ 0.31%)

Actions #13

Updated by okurz almost 2 years ago

  • Copied to action #121357: [easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:M added
Actions

Also available in: Atom PDF