action #98403
closed[easy][beginner] Make sections on build bars clickable size:S
Description
Motivation¶
Idea by vpelcak: Following pages like https://openqa.opensuse.org/group_overview/1 there are build bars showing the overview of build results, e.g. "213 passed", "33 failed". Would be nice if the individual sections of the build bars would be clickable and lead directly to the corresponding parts of results, e.g. only "failed" jobs within the build.
Acceptance criteria¶
- AC1: Clicking on the individual sections leads to /test/overview with only the selected results shown
- AC2: Hovering over build bar still shows the number of all results
Suggestions¶
Each line has already a link in the beginning, e.g. https://openqa.opensuse.org/tests/overview?distri=microos&distri=opensuse&version=Tumbleweed&build=20210907&groupid=1 . Each section of the build bar could be a link with just the additional query parameter "result=" added, e.g. https://openqa.opensuse.org/tests/overview?distri=microos&distri=opensuse&version=Tumbleweed&build=20210907&groupid=1&result=failed
Updated by okurz over 2 years ago
https://github.com/os-autoinst/openQA/blob/master/templates/webapi/main/build_progressbar.html.ep is the HTML template that generates the build bar sections. Maybe a good starting point.
Updated by okurz over 2 years ago
- Subject changed from [easy][beginner] Make sections on build bars clickable to [easy][beginner] Make sections on build bars clickable size:S
- Status changed from New to Workable
estimated in daily 2021-09-14
Updated by livdywan over 2 years ago
Discussed in the Midweekly Unblock. The current branch seems to cause problems with the layout of the bars. So the use of javascript was suggested; we're not sure it's required for this. Maybe Marius and Moritz can try and pair-program this one.
Updated by okurz over 2 years ago
- Status changed from In Progress to Workable
To be picked up again after return
Updated by kodymo over 2 years ago
- Status changed from Workable to Feedback
Updated by mkittler over 2 years ago
It is now deployed on OSD and basically works. I just see one problem with parent groups: When clicking on a parent group progress bar segment it passes the group ID of the parent group as parameter. However, it needs to pass all the group IDs of the job groups contained by that parent group instead. That's also how the normal link on the build number works (which one can use by middle-clicking on the build number).
Updated by kodymo over 2 years ago
https://github.com/os-autoinst/openQA/pull/4337
The links are fixed in this pr, I'm working on a test to check if URLs are right in the future
Updated by okurz over 2 years ago
For the future, please add a comment explaining why you consider this "Resolved" now. For example, as we discussed in the weekly, we can see the feature now live on https://openqa.suse.de/ with clickable build-bars that link to test overview pages. Based on our review in the weekly meeting we created followup #102719
Updated by okurz over 2 years ago
- Copied to action #102719: Consolidate build-bar link targets, e.g. for "failed" should show the same number as in the build bar added