Project

General

Profile

action #97097

coordination #96596: [qe-core][CI] Implement checks in the CI for common errors/coding style

[qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing (move away from my $self = shift)

Added by dvenkatachala 2 months ago. Updated 27 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
-
Start date:
2021-08-18
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

  • Syntax checkers for coding style

    In an existing Perl module or a new file is created, avoid the mix between my $self = shift and my ($self) = @_ for parameter parsing and the suggestion is to stick to my ($self) = @.
    Implement CI check to verify the parameter parsing in the files.

AC's for each item

  • AC1: Each subtask is proposed as an RFC in the os-autoinst-distri-opensuse repo.
  • AC2: There's a corresponding entry in the contributing document.
  • AC3: A CI check to verify parameter parsing in the newly created/edited files similar to [PR]

History

#1 Updated by dvenkatachala 2 months ago

  • Parent task changed from #95161 to #96596

#2 Updated by dvenkatachala 2 months ago

  • Subject changed from Add syntax checkers to the CI to propose changes over old coding style to [qe-core][CI] Add syntax checkers to the CI to propose changes over old coding style

#3 Updated by dvenkatachala 2 months ago

  • Assignee set to dvenkatachala

#4 Updated by dvenkatachala 2 months ago

  • Tracker changed from coordination to action

#5 Updated by dvenkatachala 2 months ago

  • Project changed from qam-qasle-collaboration to openQA Tests

#6 Updated by okurz about 2 months ago

  • Category set to Enhancement to existing tests

#7 Updated by punkioudi about 1 month ago

Hi Dee, I am not sure if this PR : https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13323 serves the purpose of the CI story. Plus, this ticket doesn't have a description of what you are trying to achieve within this ticket :)

#8 Updated by dvenkatachala about 1 month ago

  • Description updated (diff)

#9 Updated by dvenkatachala about 1 month ago

  • Description updated (diff)

#10 Updated by dvenkatachala 29 days ago

  • Description updated (diff)

#11 Updated by dvenkatachala 29 days ago

  • Description updated (diff)

#12 Updated by dvenkatachala 29 days ago

  • Description updated (diff)

#13 Updated by dvenkatachala 27 days ago

  • Subject changed from [qe-core][CI] Add syntax checkers to the CI to propose changes over old coding style to [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing
  • Description updated (diff)

#14 Updated by szarate 27 days ago

  • Subject changed from [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing to [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing (move away from my $self = shift)

Also available in: Atom PDF