Project

General

Profile

Actions

action #97097

open

coordination #96596: [qe-core][CI] CI/CD and Coding style improvements

[qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing (move away from my $self = shift)

Added by dvenkatachala over 2 years ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2021-08-18
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

  • Syntax checkers for coding style

    In an existing Perl module or a new file is created, avoid the mix between my $self = shift and my ($self) = @_ for parameter parsing and the suggestion is to stick to my ($self) = @.
    Implement CI check to verify the parameter parsing in the files.

AC's for each item

  • AC1: Each subtask is proposed as an RFC in the os-autoinst-distri-opensuse repo.
  • AC2: There's a corresponding entry in the contributing document.
  • AC3: A CI check to verify parameter parsing in the newly created/edited files similar to [PR]
Actions #1

Updated by dvenkatachala over 2 years ago

  • Parent task changed from #95161 to #96596
Actions #2

Updated by dvenkatachala over 2 years ago

  • Subject changed from Add syntax checkers to the CI to propose changes over old coding style to [qe-core][CI] Add syntax checkers to the CI to propose changes over old coding style
Actions #3

Updated by dvenkatachala over 2 years ago

  • Assignee set to dvenkatachala
Actions #4

Updated by dvenkatachala over 2 years ago

  • Tracker changed from coordination to action
Actions #5

Updated by dvenkatachala over 2 years ago

  • Project changed from 175 to openQA Tests
Actions #6

Updated by okurz over 2 years ago

  • Category set to Enhancement to existing tests
Actions #7

Updated by punkioudi over 2 years ago

Hi Dee, I am not sure if this PR : https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13323 serves the purpose of the CI story. Plus, this ticket doesn't have a description of what you are trying to achieve within this ticket :)

Actions #8

Updated by dvenkatachala over 2 years ago

  • Description updated (diff)
Actions #9

Updated by dvenkatachala over 2 years ago

  • Description updated (diff)
Actions #10

Updated by dvenkatachala over 2 years ago

  • Description updated (diff)
Actions #11

Updated by dvenkatachala over 2 years ago

  • Description updated (diff)
Actions #12

Updated by dvenkatachala over 2 years ago

  • Description updated (diff)
Actions #13

Updated by dvenkatachala over 2 years ago

  • Subject changed from [qe-core][CI] Add syntax checkers to the CI to propose changes over old coding style to [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing
  • Description updated (diff)
Actions #14

Updated by szarate over 2 years ago

  • Subject changed from [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing to [qe-core][CI] Add syntax checkers to the CI to verify the parameter parsing (move away from my $self = shift)
Actions #15

Updated by szarate over 1 year ago

  • Status changed from In Progress to New
  • Assignee deleted (dvenkatachala)

I guess this is not in progress anymore

Actions

Also available in: Atom PDF