Project

General

Profile

action #97097

Updated by dvenkatachala over 2 years ago

## Story 
 As a code reviewer, I would like the CI to do menial checks so that I can focus on bigger details and be more effective with my work. 
 
 ## Background 
 * Syntax checkers for coding style 
     * we have called the functions check_var('ARCH', '') and check_var('BACKEND','') in most of the perl modules, Replace these functions with already defined functions in (in the lib/Utils/Architectures.pm and lib/Utils/Backends.pm. 
      lib/Utils/Backends.pm)    
      Example: check_var('ARCH', 'aarch64') to is_aarch64 , check_var('ARCH', 's390x') to is_s390x  
     * Mix between my $self = shift and my ($self) = @_ for parameter parsing, the proposal would be to stick to my ($self) = @. @ 

 ### AC's for each item 
  * AC1: Each subtask is proposed as an RFC in the os-autoinst-distri-opensuse repo. 
  * AC2: There's a corresponding entry in the [contributing](https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/CONTRIBUTING.md#coding-style) document. 

Back