Project

General

Profile

action #93940

coordination #39719: [saga][epic] Detection of "known failures" for stable tests, easy test results review and easy tracking of known issues

coordination #19720: [epic] Simplify investigation of job failures

text thumbnail preview feels inconsistent to other screenshots size:M

Added by okurz 6 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2021-06-14
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

See links like https://openqa.opensuse.org/tests/1784596#step/logpackages/4 . When walking over screenshot thumbnails in the openQA test details page the preview appears with a nice arrow below the thumbnail. Selecting a text box looks quite different, with no arrow and the line breaking the list of steps displayed.

Acceptance criteria

  • AC1: Screenshot and text view behaviour is confirmed to be consistent by multiple power users

Suggestions

  • Discuss with mkittler the options after mkittler did the new text preview implementation
  • Ask multiple users if they like the behaviour, e.g. based on a video, a test instance or screenshots
  • Don't add more AJAX but prefer a CSS-only solution
  • Ensure the current flow of thumbnails and text boxes stays consistent
  • Screenshot boxes currently hover on top, but text boxes don't. Both should behave the same. And both should have the little arrow to indicate which result is shown (maybe it would even look better with an additional dark effect like here.

History

#1 Updated by okurz 6 months ago

  • Parent task set to #19720

#2 Updated by mkittler 6 months ago

Discuss with mkittler the options after mkittler did the new text preview implementation

I remember that last time I changed the behavior we didn't want to spend too much time on improving it further but of course that's still an option. When I remember correctly, I did the following improvements:

  1. The code for displaying finished results and the code for displaying results while the test is running should now be unified.
  2. There's no further AJAX request required when clicking on a text thumbnail.
  3. The expanded preview of a text thumbnail is more consistent with the way we display text results from external test suits.

I'd say that 1. and 2. should stay this way but of course 3. is something we might want to re-think. At least adding the arrow there as well would make sense.

#3 Updated by dheidler 6 months ago

Yes, the arrow should get added.
I would also like to see the rest of the current result row (which is currently only displayed below the currently selected result) as otherwise the next step is not directly visible for the reviewer.
They would be shown below, but depending on the size of the result box, this would require scrolling around and is also not consistent with the rest of the results, where the line is not broken.

#4 Updated by okurz 5 months ago

  • Status changed from Workable to New

moving all tickets without size confirmation by the team back to "New". The team should move the tickets back after estimating and agreeing on a consistent size

#5 Updated by okurz 5 months ago

  • Target version changed from Ready to future

#6 Updated by cdywan 3 months ago

  • Target version changed from future to Ready

As discussed in the daily we consider this important in typical workflows

#7 Updated by cdywan 3 months ago

  • Subject changed from text thumbnail preview feels inconsistent to other screenshots to text thumbnail preview feels inconsistent to other screenshots size:M
  • Description updated (diff)
  • Status changed from New to Workable

#8 Updated by dheidler 3 months ago

  • Description updated (diff)

#9 Updated by osukup about 2 months ago

  • Assignee set to osukup

#10 Updated by okurz about 2 months ago

  • Status changed from Workable to In Progress

#11 Updated by osukup about 1 month ago

  • Status changed from In Progress to Feedback

merged

#12 Updated by osukup about 1 month ago

  • Status changed from Feedback to Resolved

deployed and it works

Also available in: Atom PDF