Project

General

Profile

action #91755

coordination #71242: [epic] Unify validation in the installed system

Split functionality for validating partitioning in partitions_validator_utils into more reusable functions

Added by JERiveraMoya 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
SUSE QA - SLE 15 SP3
Start date:
2021-04-26
Due date:
% Done:

0%

Estimated time:

Description

We have created a package lib/partitions_validator_utils which group some functionality for validating partitioning, but we haven't thought much how this functions could be reused in others tests, for example:

  • validate_partition_table should contain more clear the argument to be passed.
  • Avoid conditional statements.
  • Libraries should give us the information that we need running the commands, assertion should be done on the test itself.
  • Wrap blkid/lsblk parsers with some parametrized function so it can be reused easily. lsblk has an option to be exported to json.
  • subvolume validation might be move to a different library for btrfs actions.
  • We could think to rename it to something like /lib/validators/partitioning.pm so package name will be validators::partitioning.
  • Grep for 'lsbkl' and find all occurrences and try avoid duplication (if it is too much places to refactor then consider new ticket)

For example, we have this block of code with no relation with sub validate_unpartitioned_space in lib/partitions_validator_utils.pm

In general we should split the functionality in this library to have more fine grain and document it with perlpod.


Related issues

Related to qe-yast - action #91677: [sporadic] test fails in validate_fs_tableRejected2021-04-24

Related to qe-yast - action #91758: Validate raid partitioning layout using test data instead of regexClosed2021-04-26

History

#1 Updated by JERiveraMoya 5 months ago

  • Description updated (diff)

#2 Updated by JERiveraMoya 5 months ago

  • Related to action #91677: [sporadic] test fails in validate_fs_table added

#3 Updated by JERiveraMoya 5 months ago

  • Description updated (diff)

#4 Updated by oorlov 5 months ago

  • Description updated (diff)
  • Status changed from New to Workable

#5 Updated by oorlov 5 months ago

  • Related to action #91758: Validate raid partitioning layout using test data instead of regex added

#6 Updated by JERiveraMoya 5 months ago

  • Status changed from Workable to In Progress
  • Assignee set to JERiveraMoya

#7 Updated by JERiveraMoya 5 months ago

  • Status changed from In Progress to Feedback

#8 Updated by JERiveraMoya 5 months ago

  • Status changed from Feedback to In Progress

#9 Updated by JERiveraMoya 5 months ago

  • Status changed from In Progress to Feedback

#11 Updated by JERiveraMoya 3 months ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF