openQA Project » openQA Tests

okurz wrote:

The method is part of os-autoinst-distri-opensuse, not part of os-autoinst so you can take a look into the method definition within the "lib/" folder of the test distribution. I don't have experience with the method myself and I doubt anyone from SUSE QE Tools has experience

Thanks Oliver!

Did some tests with @rfan1. Here are the results:

1. when $self->select_serial_terminal, the output will include command line, such as

   rw7ER-0-
   # (script -qe -a /dev/null -c '
   > dsidm localhost account reset_password uid=wilber,ou=people,dc=example,dc=com
   > '; echo EOS~~~$?) |& tee /dev/ttyS0
   Enter new password for uid=wilber,ou=people,dc=example,dc=com :
   

   Then script_run_interactive die because the output matches EOS~~~.
   See: https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/utils.pm#L1612

2. in the second step, the output does not match the regex because the regex we used is an array. Here is an example:
   Output is YES \n Enter passphrase for /root/testfile:,
   And regex is

   ["Are you sure.*",
   "Enter passphrase.*",
   "Verify passphrase.*",
   qr/EOS~~~(\d+)/ ]
   

   In the serial terminal, we put the items in the array together and make a regex. See: https://github.com/os-autoinst/os-autoinst/blob/master/consoles/serial_screen.pm#L140
   
   In the root console, there is no problem. Because we do the match one by one (in a for loop)
   If the check should return success when the output matches any one item in an array, we need to modify the code in os-autoinst.

3. We should use EOS~~~(\d+) to check if the command is done. Because the output will be cut according to the regex. If we use EOS~~~, the result of $? will be lost.
   see: https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/utils.pm#L1605