action #88609
closedMojolicious 9.0 compatibility
Description
Mojolicious 9.0 has just been released and there are quite a few breaking changes. Some also affect openQA, such as the use of reserved stash values as route placeholders, and need to be fixed.
Updated by kraih over 3 years ago
Started working on it in a branch. https://github.com/os-autoinst/openQA/pull/3726
Updated by livdywan over 3 years ago
- Category set to Regressions/Crashes
- Target version set to Ready
I think we should consider this part of the backlog and effectively a bug fix, because we'll be in trouble if we want to use the latest Mojolicious.
Thank you, @kraih, for being on top of it. Although I would prefer the API wasn't broken all the time, but well, it is what it is.
Updated by okurz over 3 years ago
Agreeing with cdywan, I assume this is not just "for fun" but we would need to work on that anyway at the latest when our tests break when 9.0 reaches openSUSE:Factory, right?
Updated by kraih over 3 years ago
No it's not just "for fun". :) The things i've found in openQA so far are actual bugs, like /:status being used as a route placeholder. And status is special because it allows the response code to be changed ($c->render(text => '...', status => 302)). So we might end up allowing the request URL to pick a specific response code. You get the idea. Mojolicious 9.0 turned a lot of these easy to make mistakes into exceptions.
And yes, once 9.0 reaches factory our tests would fail.
Updated by openqa_review over 3 years ago
- Due date set to 2021-03-02
Setting due date based on mean cycle time of SUSE QE Tools
Updated by kraih over 3 years ago
Mojolicious 9.0 is on the way to factory now. https://build.opensuse.org/request/show/872779
Updated by kraih over 3 years ago
The pull request should be ready now. The colored log message feature has been moved upstream and will probably be part of Mojolicious 9.01.
Updated by kraih over 3 years ago
Mojolicious 9.01 with MOJO_LOG_COLOR=1 feature is on its way to factory. https://build.opensuse.org/request/show/873064
Updated by SLindoMansilla over 3 years ago
- Has duplicate action #88696: Executing /usr/share/openqa/script/openqa-gru fails added
Updated by SLindoMansilla over 3 years ago
Executing /usr/share/openqa/script/openqa-gru fails
Version:
- openQA-4.6.1613477586.fa28c153e-lp152.3672.1.noarch
- perl-Mojolicious-9.01-lp152.350.1
# output of /usr/share/openqa/script/openqa-gru
[2021-02-17 13:07:06.55734] [3763] [warn] Deprecated use of config key '[audit]: blacklist'. Use '[audit]: blocklist' instead
Route pattern "/children/:status" contains a reserved stash value at /usr/share/openqa/script/../lib/OpenQA/WebAPI.pm line 361.
# exit code 30
Updated by kraih over 3 years ago
- Status changed from In Progress to Feedback
The PR has been merged.