action #71110
closed
Reduce waiting time in case of os-autoinst shutdown
Added by okurz over 3 years ago.
Updated over 3 years ago.
Category:
Feature requests
Description
Motivation¶
Also See #68938 . Stopping isotovideo can still take quite some seconds even though no expensive action seems to going on.
Acceptance criteria¶
- AC1: t/18-qemu-options.t (and potentially other tests) run significantly faster than before.
- AC2: Tests ensure that the shutdown time does not regress again
Suggestions¶
- Copied from action #68938: Try to reduce waiting time in case of qemu (early-)exits auto_review:"QEMU terminated before QMP connection could be established at /usr/lib/os-autoinst/OpenQA/Qemu/Proc.pm line 443":retry added
- Status changed from Workable to Feedback
- Due date set to 2020-10-15
I am setting a due date so that you can check at the due date if the package was accepted and we have all necessary requirements ready so that we can at best do the next step which would be to lower the test timeout to ensure we are always a bit faster.
0.28 is in now by the looks of it. Does the timeout still need adjusting?
As mentioned in the PR:
This saves measurably time, e.g. the os-autoinst test t/18-qemu-options.t
needs 28 seconds to execute on my system without this change and 11 seconds
with this change.
I'm not sure how much there's left to optimize. And yes, I still need to adjust the timeout. However, if we're actually enforcing that within the testsuite we should also specify in the dependency files that we require at least 0.28.
hm, actually we would only strongly depend on 0.28 for "tests" - good that we can encode that separately :)
- Due date deleted (
2020-10-15)
- Status changed from Feedback to In Progress
PR is merged, https://build.opensuse.org/package/live_build_log/devel:openQA/os-autoinst/openSUSE_Factory_PowerPC/ppc64le failed now with
[ 248s] 3: ./17-basetest.t .......................... ok
[ 248s] 3: Bailout called. Further testing stopped: test exceeds runtime limit of '5' seconds
[ 248s] 3: FAILED--Further testing stopped: test exceeds runtime limit of '5' seconds
[ 248s] 3/3 Test #3: test-perl-testsuite ..............***Failed 86.27 sec
looks a bit like the test already passed but maybe a dirty subprocess is stuck or needs longer to finish
merged. Please wait for results in OBS.
- Status changed from In Progress to Feedback
Looks like all builds succeed (unless unresolvable or blocked).
That should be enough waiting :) Thank you so far. I wanted to check what travis CI records as runtime for the individual test so that we can check on the current value. But I realized we don't record the timer output. Anyway, unless you plan for more work feel welcome to set to "Resolved" now
- Status changed from Feedback to Resolved
- Related to action #157339: os-autoinst t/14-isotovideo.t is again taking too long (>20s on my setup) size:M added
Also available in: Atom
PDF