Added by lnussel over 9 years ago. Updated almost 7 years ago.
100%
Description
the worker should have some kind of version that the webui can check. the webui should then be able to reject workers that are not sufficiently new. that helps in case of protocol changes or new mandatory features.
this is not actually of high priority as we just have to be careful when deploying new versions to deploy all machines. Annoying, but not critical
I think we also need a stricter check on using the same os-autoinst on the workers. But possibly if the worker required the os-autoinst version it was built against, we could sync this issue with that other problem.
Just my 2c on this:
Aside from displaying workers versions: i think for a communication protocol perspective (especially wrt websocket server/worker) is a good thing to have also a variable/constant identifying only the protocol version - inside the codebase - instead of the packaging version.
That allows us with a bit of more control and we can bump the protocol version number inside the code when we know we are breaking compatibility with our changes and let the worker immediately die in such case.
okurz wrote:
like https://github.com/os-autoinst/os-autoinst/blob/master/isotovideo#L55 ?
yup, i think we should do the same for the websocket/internal commands
This has been into production since 16/02/2018.