Project

General

Profile

tickets #68287

openqa redirects to startpage after login since new IDP was introduced

Added by dheidler over 1 year ago. Updated about 2 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Accounts and GDPR
Target version:
-
Start date:
2020-06-22
Due date:
% Done:

0%

Estimated time:

Description

with the new IDP login system openqa doesn't remember anymore, on which page you were:


Related issues

Related to openQA Project - action #89710: Add redirection after login compatible to the new IDP login system size:MResolved2021-03-09

History

#1 Updated by okurz over 1 year ago

  • Private changed from Yes to No

#2 Updated by mkittler over 1 year ago

This line looks suspicious: https://github.com/os-autoinst/openQA/commit/6972e6243ce9f2f49ee77f986960e696946642b3#diff-618fd7a3800afcf9fc8c47018630a7e5R145
But it has been added for a reason: https://github.com/os-autoinst/openQA/pull/3167#issuecomment-641819085

So we need to find a better solution to avoid the redirection loop.

#3 Updated by bmwiedemann about 1 year ago

For being able to redirect to the original page, we would need to pass it through, but when I debugged it last time to produce the linked commit, it just told openid to return to the /response page.

An alternative would be to use a cookie on the openQA side to keep track of the last page visited.

#4 Updated by lrupp about 1 year ago

  • Category set to Accounts and GDPR
  • Status changed from New to Workable

#5 Updated by bmwiedemann 7 months ago

  • Assignee changed from bmwiedemann to okurz

I see the /response page is called without a reference to the original page anywhere in the request. You could try to add that info in the openid.return-to value.

e.g. currently it is
openid.return_to=https://openqa.suse.de/response?oic.time=1615202655-f8e8eefa8dfa5fc5bca3

and it could become
openid.return_to=https://openqa.suse.de/response?oic.time=1615202655-f8e8eefa8dfa5fc5bca3&page=/tests/12345

#6 Updated by okurz 7 months ago

  • Related to action #89710: Add redirection after login compatible to the new IDP login system size:M added

#7 Updated by okurz 7 months ago

  • Assignee changed from okurz to bmwiedemann

Ok. This is something we can look into. I have recorded that in #89710. However, please keep in mind that this is a regression as with the previous identity provider the redirection to the original page still worked. If you think this is something useful and feasible and look into then you can do that so I assigned the ticket back to you. If you think it's not possible then you can reject this ticket and we will still try in #89710 to have at least newer openQA versions support that again, that's ok as well :)

#8 Updated by bmwiedemann about 2 months ago

  • Status changed from Workable to Rejected

I reject this issue, as I do not want to get into coding ipsilon/python and a possible workaround exists on the client side.

Also available in: Atom PDF