tickets #68287
closedopenqa redirects to startpage after login since new IDP was introduced
0%
Description
with the new IDP login system openqa doesn't remember anymore, on which page you were:
- Go to some openQA page while not being logged in (eg. https://openqa.suse.de/tests/4341299)
- Click Login
- Enter your Credentials ans submit
- You are redirected to https://openqa.suse.de insted of https://openqa.suse.de/tests/4341299
Updated by mkittler almost 4 years ago
This line looks suspicious: https://github.com/os-autoinst/openQA/commit/6972e6243ce9f2f49ee77f986960e696946642b3#diff-618fd7a3800afcf9fc8c47018630a7e5R145
But it has been added for a reason: https://github.com/os-autoinst/openQA/pull/3167#issuecomment-641819085
So we need to find a better solution to avoid the redirection loop.
Updated by bmwiedemann almost 4 years ago
For being able to redirect to the original page, we would need to pass it through, but when I debugged it last time to produce the linked commit, it just told openid to return to the /response page.
An alternative would be to use a cookie on the openQA side to keep track of the last page visited.
Updated by lrupp almost 4 years ago
- Category set to Accounts
- Status changed from New to Workable
Updated by bmwiedemann about 3 years ago
- Assignee changed from bmwiedemann to okurz
I see the /response page is called without a reference to the original page anywhere in the request. You could try to add that info in the openid.return-to value.
e.g. currently it is
openid.return_to=https://openqa.suse.de/response?oic.time=1615202655-f8e8eefa8dfa5fc5bca3
and it could become
openid.return_to=https://openqa.suse.de/response?oic.time=1615202655-f8e8eefa8dfa5fc5bca3&page=/tests/12345
Updated by okurz about 3 years ago
- Related to action #89710: Add redirection after login compatible to the new IDP login system size:M added
Updated by okurz about 3 years ago
- Assignee changed from okurz to bmwiedemann
Ok. This is something we can look into. I have recorded that in #89710. However, please keep in mind that this is a regression as with the previous identity provider the redirection to the original page still worked. If you think this is something useful and feasible and look into then you can do that so I assigned the ticket back to you. If you think it's not possible then you can reject this ticket and we will still try in #89710 to have at least newer openQA versions support that again, that's ok as well :)
Updated by bmwiedemann over 2 years ago
- Status changed from Workable to Rejected
I reject this issue, as I do not want to get into coding ipsilon/python and a possible workaround exists on the client side.