QA (public) » openQA Project (public)

The dependencies have been added a very long time ago:

commit 55a8d9be1
Author: Michal Hrusecky <Michal@Hrusecky.net>
Date:   Tue Apr 8 11:09:17 2014 +0200

    Start workers after webui even without apache

diff --git a/systemd/openqa-worker@.service b/systemd/openqa-worker@.service
index a199f58eb..ee065307d 100644
--- a/systemd/openqa-worker@.service
+++ b/systemd/openqa-worker@.service
@@ -4,8 +4,8 @@
 # replace '1' with the instance number you want
 [Unit]
 Description=openQA Worker #%i
-Wants=apache2.service
-After=apache2.service
+Wants=apache2.service openqa-webui.service
+After=apache2.service openqa-webui.service

and

commit 5d8bf4eaa
Author: Ludwig Nussel <ludwig.nussel@suse.de>
Date:   Thu Jun 6 16:23:00 2013 +0200

    depend on apache

diff --git a/systemd/openqa-worker@.service b/systemd/openqa-worker@.service
index fff1b0019..41be8a1dd 100644
--- a/systemd/openqa-worker@.service
+++ b/systemd/openqa-worker@.service
@@ -4,6 +4,8 @@
 # replace '1' with the instance number you want
 [Unit]
 Description=openQA Worker #%i
+Wants=apache2.service
+After=apache2.service

for me again bad examples of git commit messages. We know what is done already from the code change but we do not know why. I guess the use case is for a single-instance setup to synchronise the services which IMHO makes sense. The automatic reconnect of the worker might obsolete at least the dependency on the webui.

The relation to "fetchneedles" I do not understand. Before changing this we should understand the requirements for both the single-instance as well as distributed setup. The "webui installed but local worker connected elsewhere" use case is a corner case we should try to cover as well but if we can not we would need to rely on the user to tinker with the local service definitions.

apache2 is most likely really not relevant here because we don't even provide configs to reverse-proxy a worker through apache. However, starting the openqa-webui in case it is installed and a worker is started is quite a sane default to me. I can understand that this default might not work for every user but this is part of the reason why distributions switched to systemd. It enables the user to easily customize and adjust services to their needs.

I see it similar to @okurz that only starting the worker is not a default use-case. Therefore, @ggardet_arm I'd currently suggest you to adjust the service files to your needs with an appropriate service override (e.g. use systemctl edit openqa-worker). However I'm fully open for discussions if we should really keep Wants=apache2 for openqa-worker.service.

Yes, I think the apache2 requirement is something we do not need anymore at all, proposed to get rid of this with https://github.com/os-autoinst/openQA/pull/3076

Is there an option to tell: "Start after X, only if X is enabled. Otherwise, ignore." ?

Because ATM, I disable openqa-webui/openqa-gru services, but they start again at each boot due to openqa-worker service which is a bit annoying.
I will have a look at systemctl edit openqa-worker if there is no better defaults.

Maybe it works to mask the openqa-webui service. (Of course that's not a good solution if you want to start the service occasionally manually but just not by default.)

mkittler wrote:

Maybe it works to mask the openqa-webui service. (Of course that's not a good solution if you want to start the service occasionally manually but just not by default.)

Is this the recommended solution then? Or are you still planning on proposing a change to the dependencies?