action #66268
closedEnsure proper evaluation and download of _URL parameters on "jobs post", not only "isos post" (was: There is FOO_URL in settings, but no FOO in settings, the job failed when using `jobs post`)
0%
Description
Acceptance criteria¶
- AC1: The _URL evaluation including setting an asset filename from the corresponding _URL variable works for "jobs post" similar to "isos post"
Further details¶
Original description:
According to https://github.com/os-autoinst/openQA/pull/2877#issuecomment-614331728. I did a test in my local environment, a job with HDD_1_URL, but has no HDD_1, it failed.
Here is the test http://10.67.19.103/tests/46#settings
I did that by using openqa-clone-job .... HDD_1_URL=xxx HDD_1=
Suggestion:
HDD_1 should be added in job's setting, then the job should be success.
Updated by okurz over 4 years ago
- Category set to Regressions/Crashes
This sounds like a regression. http://open.qa/docs/#_asset_handling describes "ISO_1_URL=http://trusted.com/foo.iso would […] download the file foo.iso […] and set ISO_1=foo.iso". The same I assumed to be true for HDD and I thought this would be covered by tests. So as a temporary workaround your suggestion can be done by the user and we should ensure that our code does it automatically for a proper fix. Do you agree?
Updated by Xiaojing_liu over 4 years ago
- Category deleted (
Regressions/Crashes)
okurz wrote:
This sounds like a regression. http://open.qa/docs/#_asset_handling describes "ISO_1_URL=http://trusted.com/foo.iso would […] download the file foo.iso […] and set ISO_1=foo.iso". The same I assumed to be true for HDD and I thought this would be covered by tests. So as a temporary workaround your suggestion can be done by the user and we should ensure that our code does it automatically for a proper fix. Do you agree?
Totally agree with you.
Updated by AdamWill over 4 years ago
Just to clarify a bit, I don't think this is exactly a regression, but rather, it's a difference between isos post and jobs post.
When we added the _URL stuff - all the way back in https://github.com/os-autoinst/openQA/pull/426 - we didn't put it in the jobs post path at all (if job posting was actually a thing back then, I'm not sure). It has always worked as intended in ISO posting (which is how we, Fedora, mostly use it).
Then back in 2018, okurz added the asset download feature to jobs post in this commit: https://github.com/os-autoinst/openQA/commit/2c27c9070637ffd6bce0b1e181c51a06cfa9a1a4 - before that commit the jobs post path just didn't try and do asset downloads at all - but got the ordering a bit wrong, as I explained in https://github.com/os-autoinst/openQA/pull/2877#issuecomment-614331728 .
So I don't think this has ever actually worked on the jobs post path - until 2c27c907 that path just didn't attempt asset downloads at all, and since 2c27c907 that path has done asset downloads but because of the ordering problem it only works if the FOO value is explicitly set as well as FOO_URL.
This probably hasn't been noticed till now as we (Fedora) have been the main users of the _URL stuff and we just don't use jobs post much, we always schedule via isos post.
Updated by okurz over 4 years ago
- Subject changed from There is FOO_URL in settings, but no FOO in settings, the job failed when using `jobs post` to Ensure proper evaluation and download of _URL parameters on "jobs post", not only "isos post" (was: There is FOO_URL in settings, but no FOO in settings, the job failed when using `jobs post`)
- Description updated (diff)
- Category changed from Regressions/Crashes to Feature requests
- Target version set to future
That's very good to know. So I will mark it as "feature request" and update the subject line and description accordingly. Thanks.
Updated by Xiaojing_liu over 4 years ago
- Status changed from New to In Progress
- Assignee set to Xiaojing_liu
- Target version changed from future to Current Sprint
Updated by Xiaojing_liu over 4 years ago
Updated by Xiaojing_liu over 4 years ago
- Status changed from In Progress to Feedback
PR has been merged
Updated by livdywan over 4 years ago
- Status changed from Feedback to Resolved
I presume this sorted - unless @AdamWill you found unwanted side effects afterall? So I'm highlighting you just in case.