Project

General

Profile

action #61901

[functional][y] Check if wicked is running for yast command line tests

Added by riafarov almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
Start date:
2020-01-08
Due date:
2020-03-24
% Done:

0%

Estimated time:
2.00 h
Difficulty:

Description

Motivation

As per comment in https://bugzilla.novell.com/show_bug.cgi?id=1148679 Josef has stated that tests require wicked to be running, as yast2 lan in general is useful in case of wicked only.
So, executing this test with NM doesn't make sense in general.

Therefore, test should be executed with wicked setup only. Additionally, we can add such check to simplify investigation, as in case wicked is down, tests will fail.


Related issues

Copied to openQA Tests - action #64731: [functional][y] generate TW image with wicked and use it in yast2_cmdline and nis MM test suitesResolved2020-01-082020-05-19

History

#1 Updated by okurz almost 2 years ago

  • Category set to Enhancement to existing tests

#2 Updated by riafarov over 1 year ago

  • Due date changed from 2020-02-11 to 2020-02-25

#3 Updated by riafarov over 1 year ago

  • Due date changed from 2020-02-25 to 2020-03-10

#4 Updated by JERiveraMoya over 1 year ago

  • Due date changed from 2020-03-10 to 2020-03-24

#5 Updated by JERiveraMoya over 1 year ago

  • Status changed from New to Workable
  • Estimated time set to 2.00 h

#6 Updated by ybonatakis over 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis

#7 Updated by ybonatakis over 1 year ago

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/9746

I have to run a negative test but i think it works just fine.
If systemctl status returns 0 then wicked is running
for any other return code die.
The funtion systemctl uses the output of the script_run. To do so
the function is called with ignore_failure enabled. With the ignore_failure disabled will call the assert_script_run and the return code might be different

#8 Updated by ybonatakis over 1 year ago

  • Status changed from In Progress to Feedback

#9 Updated by ybonatakis over 1 year ago

Actually we have nothing to do on this ticket as there is already a check introduced by dbe50c9b66. This is checking if NetworkManager is the network controller and returns.

#10 Updated by ybonatakis over 1 year ago

i am closing the PR

#11 Updated by riafarov over 1 year ago

  • Status changed from Feedback to Workable

I see that this ticket wasn't refined well. We are talking about yast cmd tests here (https://openqa.opensuse.org/tests/1166336#step/yast2_cmdline/24 ) as mentioned in the bug. So the commit you've mentioned doens't address this issue. However, we can easily reuse some parts of the code there.

#12 Updated by ybonatakis over 1 year ago

  • Status changed from Workable to In Progress

#14 Updated by ybonatakis over 1 year ago

  • Status changed from In Progress to Feedback

#15 Updated by riafarov over 1 year ago

https://openqa.opensuse.org/tests/overview?distri=opensuse&version=Tumbleweed&build=20200320&groupid=38 yast_ui_devel is scheduled there. Was cancelled because yast2_ncurses fails

#16 Updated by riafarov over 1 year ago

  • Status changed from Feedback to Resolved

riafarov will create follow up ticket to make the test suite work on TW.

#17 Updated by ybonatakis over 1 year ago

  • Copied to action #64731: [functional][y] generate TW image with wicked and use it in yast2_cmdline and nis MM test suites added

Also available in: Atom PDF