action #59097

The test result overview page display the test suite name not job template name

Added by Xiaojing_liu 5 months ago. Updated 3 months ago.

Status:ResolvedStart date:05/11/2019
Priority:NormalDue date:
Assignee:Xiaojing_liu% Done:

0%

Category:Concrete Bugs
Target version:Current Sprint
Difficulty:
Duration:

Description

Example:
The YAML is

defaults: 
  x86_64:
    machine: 64bit 
    priority: 20
    settings: 
        ISO_MAXSIZE: !!str 4700378000
products:
    aaa:
      distri: sle
      version: 12-SP5 
      flavor: Server-DVD 
scenarios:
  x86_64:
    aaa: 
    - create_hdd_textmode_test:
        testsuite: create_hdd_textmode
        settings:
           ISO_MAXSIZE: !!str 47003770
    - create_hdd_textmode_test2:
        testsuite: create_hdd_textmode
        settings:
           ISO_MAXSIZE: !!str 470037810

When trigger the test suite using `client isos post TEST=`, the result is 

./client isos post --host http://127.0.0.1:9526 DISTRI=sle VERSION=12-SP5 ARCH=x86_64 FLAVOR=Server-DVD BUILD=0287 _GROUP_ID=5 TEST=create_hdd_textmode
{ count => 2, failed => [], ids => [71, 72], scheduled_product_id => 17 }

there are two jobs were triggered. It is expected result.

However, there was only one test result in Test result overview page.
create_hdd_textmode status

Screenshot_20191105_170403.png (152 KB) Xiaojing_liu, 05/11/2019 10:42 am

Screenshot_20191105_170456.png (103 KB) Xiaojing_liu, 05/11/2019 10:42 am

8994
8997

History

#1 Updated by Xiaojing_liu 5 months ago

add the test record.

#2 Updated by okurz 5 months ago

  • Category set to Feature requests

#3 Updated by Xiaojing_liu 5 months ago

  • Description updated (diff)

#4 Updated by coolo 5 months ago

  • Category changed from Feature requests to Concrete Bugs
  • Target version set to Ready

This is clearly a bug and should be fixed rather soonish if we want to get rid of test suites

#5 Updated by Xiaojing_liu 5 months ago

Maybe there is a feature request in this ticket. If we write the YAML as the example, and use client isos post TEST=xxx to trigger a job, two jobs are triggered. But if we want to trigger one job with the correct setting, seems like there is no good way to do that. Maybe we could provide a way to trigger job by job_template_name.

#6 Updated by Xiaojing_liu 5 months ago

  • Status changed from New to In Progress
  • Assignee set to Xiaojing_liu
  • Target version changed from Ready to Current Sprint

#8 Updated by okurz 4 months ago

@Xiaojing_liu your last update in this ticket was from 19 days ago which is a bit long ago. Would you care to update the ticket with the current status, the problems and the planned next steps?

#9 Updated by Xiaojing_liu 4 months ago

I tried to fix this ticket in three ways, but they did not work well. the ways were:

  1. using settings_hash to get the job_template_name while getting job's information. (when loading all jobs, the performance was very bad.) (the first solution in pr #2468)
  2. when getting jobs' information, saving all job_template_name as a hash ({job_id => job_template_name, ....}). the performance was very bad if each job has a job_template_name. (the final code in pr #2468)
  3. when getting a job's information, doing one column search in job_settings database ($database->search({job_id => xxx, key => 'JOB_TEMPLATE_NAME'})). the performance was bad. (I tested this solution in my local environment using OSD data. Because the performance was bad, I did not commit this code)

So I closed the pull request https://github.com/os-autoinst/openQA/pull/2468.

Try to change the TEST to JOB_TEMPLATE_NAME directly. Commit a new pull request https://github.com/os-autoinst/openQA/pull/2553.

#10 Updated by okurz 4 months ago

PR merged. We can try to work on the still to be done suggestions from https://github.com/os-autoinst/openQA/pull/2553

#11 Updated by mkittler 4 months ago

  • Status changed from In Progress to Resolved
  • Target version changed from Current Sprint to Done

PR has been merged and it works in production: https://openqa.opensuse.org/tests/overview?groupid=24

#12 Updated by okurz 4 months ago

  • Status changed from Resolved to In Progress
  • Target version changed from Done to Current Sprint

We at least do not have https://github.com/os-autoinst/openQA/pull/2553/files#r352361632 covered, i.e. START_AFTER_TEST should look for job template name, not test suite name.

#13 Updated by Xiaojing_liu 4 months ago

The pr https://github.com/os-autoinst/openQA/pull/2553 has caused a new bug:
1. When the parent job is added into YAML with an alias, the _sort_dep function works wrong.
2. when the START_AFTER_TEST is re-defined in YAML with the parent test's alias, the parent test will not be triggered.

#14 Updated by cdywan 4 months ago

Xiaojing_liu wrote:

The pr https://github.com/os-autoinst/openQA/pull/2553 has caused a new bug:

1. When the parent job is added into YAML with an alias, the _sort_dep function works wrong.

2. when the START_AFTER_TEST is re-defined in YAML with the parent test's alias, the parent test will not be triggered.

Should this be a new ticket? I'm not clear from the last two comments if this ticket is resolved, and/or if there's a new issue here. Could you clarify?

#15 Updated by okurz 4 months ago

I prefer to keep this ticket for the general handling of job template names. Please also see my scratch refactoring https://github.com/os-autoinst/openQA/pull/2610 to show how I envision the names of jobs is affected.

#17 Updated by okurz 3 months ago

We merged this yesterday, it's live on o3. Unless you plan further work yourself we can rebase https://github.com/os-autoinst/openQA/pull/2610 and see what is left to do.

#18 Updated by Xiaojing_liu 3 months ago

okurz wrote:

We merged this yesterday, it's live on o3. Unless you plan further work yourself we can rebase https://github.com/os-autoinst/openQA/pull/2610 and see what is left to do.

Do you mean we should compare to pr #2610 to see if there is something else we need to do?

#19 Updated by okurz 3 months ago

Yes. And I suggest to do that by rebasing https://github.com/os-autoinst/openQA/pull/2610 . Anyone can try to do that.

If you do not plan any further steps for this specific ticket yourself I suggest you unassign for the time being. I am also ok if you close the ticket as "Resolved" because the original issue is solved.

#20 Updated by Xiaojing_liu 3 months ago

okurz wrote:

Yes. And I suggest to do that by rebasing https://github.com/os-autoinst/openQA/pull/2610 . Anyone can try to do that.


If you do not plan any further steps for this specific ticket yourself I suggest you unassign for the time being. I am also ok if you close the ticket as "Resolved" because the original issue is solved.

I prefer to close the ticket as "Resolved". Do I need to add a new ticket for pr #2610?

#21 Updated by okurz 3 months ago

No, it's ok. Just close this ticket. Eventually I will rebase my PR

#22 Updated by Xiaojing_liu 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF