Actions
action #57785
closedRemove all assets in iso
Description
Remove .sha256 file (if exists) when removing .iso assets
Actions
Added by andriinikitin over 4 years ago. Updated over 4 years ago.
Description
Remove .sha256 file (if exists) when removing .iso assets
I disagree - this is way too specific for OBS projects. But you'd need to register the asset with the jobs so they are considered at all
(which would potentially pollute our DB - why exactly are we syncing them?)
rsync.pl way is to read all .iso files as part of generating isos post command to provide ISO_CHECKSUM (and sometimes ISO_CHECKSUM_1?), which sounds inefficient way to do things (and wrong, because the file might be corrupted during rsync).
Can we always carry .sha256 files together with .iso instead?
After studying the code I think this is actually a bug. The code intentionally ignores unknown files with no explanation or even a log message.
These checksums shouldn't be in 'iso' at all - but in 'other' and tracked as job setting with ASSET_\d+
Let's redefine this one to what Christian wrote
So actual problem with sha256 files was started when openqa-trigger-from-ibs started carrying .sha256 files together with .iso files.
Now the problem is fixed with commit below and the scripts do register .sha256 fiels as 'other' assets:
checked on osd, found no sha256 files in /var/lib/openqa/share/factory/iso and I assume we are good.