action #57785

Remove all assets in iso

Added by andriinikitin 5 months ago. Updated 3 months ago.

Status:ResolvedStart date:08/10/2019
Priority:NormalDue date:
Assignee:cdywan% Done:

0%

Category:Concrete Bugs
Target version:Done
Difficulty:
Duration:

Description

Remove .sha256 file (if exists) when removing .iso assets


Related issues

Related to openQA Project - action #59151: Move sha256 files to 'other' Resolved 06/11/2019

History

#1 Updated by coolo 5 months ago

I disagree - this is way too specific for OBS projects. But you'd need to register the asset with the jobs so they are considered at all

#2 Updated by coolo 5 months ago

(which would potentially pollute our DB - why exactly are we syncing them?)

#3 Updated by andriinikitin 5 months ago

rsync.pl way is to read all .iso files as part of generating isos post command to provide ISO_CHECKSUM (and sometimes ISO_CHECKSUM_1?), which sounds inefficient way to do things (and wrong, because the file might be corrupted during rsync).
Can we always carry .sha256 files together with .iso instead?

#4 Updated by okurz 4 months ago

  • Category set to Feature requests

#5 Updated by cdywan 4 months ago

  • Category changed from Feature requests to Concrete Bugs
  • Status changed from New to In Progress
  • Assignee set to cdywan
  • Target version set to Current Sprint

After studying the code I think this is actually a bug. The code intentionally ignores unknown files with no explanation or even a log message.

#6 Updated by coolo 4 months ago

These checksums shouldn't be in 'iso' at all - but in 'other' and tracked as job setting with ASSET_\d+

#7 Updated by coolo 4 months ago

#8 Updated by coolo 4 months ago

  • Subject changed from Remove .sha256 file when removing .iso assets to Remove all assets in iso

Let's redefine this one to what Christian wrote

#9 Updated by cdywan 3 months ago

  • Status changed from In Progress to Feedback

#10 Updated by andriinikitin 3 months ago

So actual problem with sha256 files was started when openqa-trigger-from-ibs started carrying .sha256 files together with .iso files.
Now the problem is fixed with commit below and the scripts do register .sha256 fiels as 'other' assets:

https://gitlab.suse.de/openqa/openqa-trigger-from-ibs/commit/6abdaa8b09bbdba9584ca8f0db846b4694ad12b1

#11 Updated by okurz 3 months ago

  • Status changed from Feedback to Resolved
  • Target version changed from Current Sprint to Done

checked on osd, found no sha256 files in /var/lib/openqa/share/factory/iso and I assume we are good.

Also available in: Atom PDF