Project

General

Profile

Actions
Copy link

action #57785

closed

Remove all assets in iso

Added by andriinikitin over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
livdywan
Category:
Regressions/Crashes
Target version:
Done
Start date:
2019-10-08
Due date:
% Done:

0%

Estimated time:

Description

Remove .sha256 file (if exists) when removing .iso assets

Related issues 1 (0 open — 1 closed)

Related to openQA Project - action #59151: Move sha256 files to 'other'Resolvedandriinikitin2019-11-06

Actions
Actions
Copy link
 #1

Updated by coolo over 4 years ago

I disagree - this is way too specific for OBS projects. But you'd need to register the asset with the jobs so they are considered at all

Actions
Copy link
 #2

Updated by coolo over 4 years ago

(which would potentially pollute our DB - why exactly are we syncing them?)

Actions
Copy link
 #3

Updated by andriinikitin over 4 years ago

rsync.pl way is to read all .iso files as part of generating isos post command to provide ISO_CHECKSUM (and sometimes ISO_CHECKSUM_1?), which sounds inefficient way to do things (and wrong, because the file might be corrupted during rsync).
Can we always carry .sha256 files together with .iso instead?

Actions
Copy link
 #4

Updated by okurz over 4 years ago

  • Category set to Feature requests
Actions
Copy link
 #5

Updated by livdywan over 4 years ago

  • Category changed from Feature requests to Regressions/Crashes
  • Status changed from New to In Progress
  • Assignee set to livdywan
  • Target version set to Current Sprint

After studying the code I think this is actually a bug. The code intentionally ignores unknown files with no explanation or even a log message.

Actions
Copy link
 #6

Updated by coolo over 4 years ago

These checksums shouldn't be in 'iso' at all - but in 'other' and tracked as job setting with ASSET_\d+

Actions
Copy link
 #7

Updated by coolo over 4 years ago

Actions
Copy link
 #8

Updated by coolo over 4 years ago

  • Subject changed from Remove .sha256 file when removing .iso assets to Remove all assets in iso

Let's redefine this one to what Christian wrote

Actions
Copy link
 #9

Updated by livdywan over 4 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #10

Updated by andriinikitin over 4 years ago

So actual problem with sha256 files was started when openqa-trigger-from-ibs started carrying .sha256 files together with .iso files.
Now the problem is fixed with commit below and the scripts do register .sha256 fiels as 'other' assets:

https://gitlab.suse.de/openqa/openqa-trigger-from-ibs/commit/6abdaa8b09bbdba9584ca8f0db846b4694ad12b1

Actions
Copy link
 #11

Updated by okurz over 4 years ago

  • Status changed from Feedback to Resolved
  • Target version changed from Current Sprint to Done

checked on osd, found no sha256 files in /var/lib/openqa/share/factory/iso and I assume we are good.

Actions
Copy link

Also available in: Atom PDF