action #57266

Forbid test suite name changes if used in job groups

Added by pcervinka 6 months ago. Updated 5 months ago.

Status:ResolvedStart date:24/09/2019
Priority:NormalDue date:
Assignee:cdywan% Done:

0%

Category:Feature requests
Target version:Done
Difficulty:medium
Duration:

Description

When is test suite renamed or deleted, changes are not propagated to job group configuration in YAML.
It is behavior change when comparing to old style of job group definition.

Reproduction scenario:
1. Rename or delete test suite
2. Check job group definition in YAML, test suite is still present or has old name

Note: Sorry, if I made duplicate case(didn't find).

History

#1 Updated by pcervinka 6 months ago

  • Description updated (diff)

#2 Updated by coolo 6 months ago

I assume this is about test suites that are only used in one job group? We want to eliminate those anyway

#3 Updated by pcervinka 6 months ago

Could be related, but it is behavior change and unaware(used to old things) user can be surprised.
For example I was adding new test suite to YAML schedule and editor complained about other not existing test suite.
It was easy to fix(just removed it), but it means that users don't expect it (to manually go over all job group definitions and delete/rename test suite).

#4 Updated by coolo 6 months ago

The yaml config file is user input and we won't touch it. But what we can do is forbid deleting/renaming test suites if they are used.

#5 Updated by coolo 6 months ago

  • Subject changed from [YAML][tools] Test suite changes are not propagated to YAML to Forbid test suite changes if used in job groups
  • Category set to Feature requests
  • Target version set to Ready
  • Difficulty set to medium

#6 Updated by cdywan 6 months ago

coolo wrote:

The yaml config file is user input and we won't touch it. But what we can do is forbid deleting/renaming test suites if they are used.

We can point out the job group(s) the respective test suite is being used in. And as a side effect users will be more aware of where a test suite is being used rather than silently changing all affected job groups.

#7 Updated by coolo 6 months ago

  • Subject changed from Forbid test suite changes if used in job groups to Forbid test suite name changes if used in job groups

We're talking about the name of the test suite only - I clarified the title

#8 Updated by pcervinka 6 months ago

coolo wrote:

The yaml config file is user input and we won't touch it. But what we can do is forbid deleting/renaming test suites if they are used.

If I understand well, it means manually remove test suite from all YAML job groups, rename and add back again with new name.
Quite difference in action when you compare to non-yaml solution(almost one click action).

#9 Updated by coolo 6 months ago

As I mentioned: the trend is to eliminate the need for frequent test suite changes

#10 Updated by pvorel 6 months ago

coolo wrote:

As I mentioned: the trend is to eliminate the need for frequent test suite changes

Despite the trend, sometimes changes are needed (sometimes even complex changes).
I should have checked the code & doc for this feature better before. If I had known this feature, I wouldn't have voluntarily changed it to yaml.

Is this incompatibility change documented somewhere?

#12 Updated by cdywan 6 months ago

pvorel wrote:

Is this incompatibility change documented somewhere?

This actually needs to be documented explicitly. The Job group editor section only mentions configuring a group in YAML, but it doesn't mention how this affects test suites. I would indeed suggest to cover this in this ticket as well.

#13 Updated by cdywan 6 months ago

  • Status changed from New to In Progress
  • Assignee set to cdywan

#14 Updated by cdywan 6 months ago

#15 Updated by cdywan 6 months ago

  • Status changed from In Progress to Feedback

#16 Updated by cdywan 5 months ago

  • Status changed from Feedback to Resolved
  • Target version changed from Ready to Current Sprint

#17 Updated by mkittler 5 months ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF