action #54002
closed
[qe-core][functional] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call
Added by dheidler almost 5 years ago.
Updated about 3 years ago.
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Description
Acceptance criteria¶
- AC1: There are no occurrences of /._run.[' "]zypper./
e.g.:
# replace
$ret = script_run("zypper -n $command $printer; ( exit \${PIPESTATUS[0]} )", $timeout);
# to
$ret = zypper_call("-n $command $printer");
The remaining occurences (after #51467 was done) where zypper is calles without using zypper_call are eg:
- One liner scripts where eg zypper output is piped somewhere
- Calls to
zypper lifecycle that don't support the global -n option that zypper_call always adds
So we should decide, if they are worth being replaced as well.
- Copied from action #51467: [functional][u] Change all occurrences of /.*_run.[' "]zypper.*/ to zypper_call added
- Priority changed from Normal to High
- Description updated (diff)
- Status changed from New to Workable
- Priority changed from High to Normal
- Target version set to Milestone 28
- Estimated time set to 42.00 h
- Status changed from Workable to In Progress
- Status changed from In Progress to Feedback
Imho we should keep them as is, they all one liners and the effort to change that would be too big for too little gain
- Target version changed from Milestone 28 to Milestone 30
needs to be discussed offline
- Subject changed from [functional][u] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call to [qe-core][functional] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call
- Status changed from Feedback to Rejected
I think there are more important topics to do, the remaining use does not seem to cause problem to test execution. Can be fixed on the fly when modifying tests otherwise.
Also available in: Atom
PDF