Project

General

Profile

Actions
Copy link

action #54002

closed

[qe-core][functional] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call

Added by dheidler almost 5 years ago. Updated about 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
jorauch
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Start date:
2019-05-14
Due date:
% Done:

0%

Estimated time:
42.00 h
Difficulty:

Description

Acceptance criteria

  • AC1: There are no occurrences of /._run.[' "]zypper./

e.g.:

# replace
$ret = script_run("zypper -n $command $printer; ( exit \${PIPESTATUS[0]} )", $timeout);
# to
$ret = zypper_call("-n $command $printer");

The remaining occurences (after #51467 was done) where zypper is calles without using zypper_call are eg:

  • One liner scripts where eg zypper output is piped somewhere
  • Calls to zypper lifecycle that don't support the global -n option that zypper_call always adds

So we should decide, if they are worth being replaced as well.

Related issues 1 (0 open — 1 closed)

Copied from openQA Tests - action #51467: [functional][u] Change all occurrences of /.*_run.[' "]zypper.*/ to zypper_callResolveddheidler2019-05-14

Actions
Actions
Copy link
 #1

Updated by dheidler almost 5 years ago

  • Copied from action #51467: [functional][u] Change all occurrences of /.*_run.[' "]zypper.*/ to zypper_call added
Actions
Copy link
 #2

Updated by SLindoMansilla over 4 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #3

Updated by SLindoMansilla over 4 years ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Priority changed from High to Normal
  • Target version set to Milestone 28
  • Estimated time set to 42.00 h
Actions
Copy link
 #4

Updated by jorauch over 4 years ago

  • Assignee set to jorauch
Actions
Copy link
 #5

Updated by jorauch over 4 years ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #6

Updated by jorauch over 4 years ago

  • Status changed from In Progress to Feedback

Imho we should keep them as is, they all one liners and the effort to change that would be too big for too little gain

Actions
Copy link
 #7

Updated by mgriessmeier over 4 years ago

  • Target version changed from Milestone 28 to Milestone 30

needs to be discussed offline

Actions
Copy link
 #8

Updated by tjyrinki_suse over 3 years ago

  • Subject changed from [functional][u] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call to [qe-core][functional] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call
Actions
Copy link
 #9

Updated by tjyrinki_suse about 3 years ago

  • Status changed from Feedback to Rejected

I think there are more important topics to do, the remaining use does not seem to cause problem to test execution. Can be fixed on the fly when modifying tests otherwise.

Actions
Copy link

Also available in: Atom PDF