action #54002

[functional][u] Change even more occurrences of /.*_run.[' "]zypper.*/ to zypper_call

Added by dheidler 9 months ago. Updated 3 months ago.

Status:FeedbackStart date:14/05/2019
Priority:NormalDue date:
Assignee:jorauch% Done:

0%

Category:Enhancement to existing testsEstimated time:42.00 hours
Target version:SUSE QA tests - Milestone 30
Difficulty:
Duration:

Description

Acceptance criteria

  • AC1: There are no occurrences of /.*_run.[' "]zypper.*/

e.g.:

# replace
$ret = script_run("zypper -n $command $printer; ( exit \${PIPESTATUS[0]} )", $timeout);
# to
$ret = zypper_call("-n $command $printer");

The remaining occurences (after #51467 was done) where zypper is calles without using zypper_call are eg:

  • One liner scripts where eg zypper output is piped somewhere
  • Calls to zypper lifecycle that don't support the global -n option that zypper_call always adds

So we should decide, if they are worth being replaced as well.


Related issues

Copied from openQA Tests - action #51467: [functional][u] Change all occurrences of /.*_run.[' "]zy... Resolved 14/05/2019

History

#1 Updated by dheidler 9 months ago

  • Copied from action #51467: [functional][u] Change all occurrences of /.*_run.[' "]zypper.*/ to zypper_call added

#2 Updated by SLindoMansilla 6 months ago

  • Priority changed from Normal to High

#3 Updated by SLindoMansilla 5 months ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Priority changed from High to Normal
  • Target version set to Milestone 28
  • Estimated time set to 42.00

#4 Updated by jorauch 4 months ago

  • Assignee set to jorauch

#5 Updated by jorauch 4 months ago

  • Status changed from Workable to In Progress

#6 Updated by jorauch 4 months ago

  • Status changed from In Progress to Feedback

Imho we should keep them as is, they all one liners and the effort to change that would be too big for too little gain

#7 Updated by mgriessmeier 3 months ago

  • Target version changed from Milestone 28 to Milestone 30

needs to be discussed offline

Also available in: Atom PDF