action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die() - openQA Project - openSUSE Project Management Tool

Custom queries

All 'new' issues w/o assignee, sorted by version/priority
All auto_review tickets
All auto_review+force_result tickets
openQA Infrastructure Project
openqa-review - Closed tickets last updated by openqa-review, last 30 days
QA roadmap long-term
QA SLE functional
QA SLE Functional - closed in last 14 days
QA SLE Functional - High, need to be refined
QA SLE Functional - over cycle time median
QA SLE u
QA SLE y
QA tools (tag not necessary in openQA and subprojects)
QA tools tag (tag not necessary in openQA and subprojects; excluding tickets in "Ready" version as they are already on the backlog)
QAC - Backlog
QE tools team - backlog (ready issues)
QE tools team - backlog (w/o infra)
QE tools team - backlog SLA high
QE tools team - backlog SLA immediate
QE tools team - backlog SLA no immediate/urgent in feedback/blocked
QE tools team - backlog SLA normal
QE tools team - backlog SLA urgent
QE tools team - backlog SLO high
QE tools team - backlog SLO normal
QE tools team - backlog SLO urgent
QE tools team - backlog, high-level view (epics and higher)
QE tools team - backlog, non-reactive work, needs parent
QE tools team - backlog, top-level view (all sagas)
QE tools team - closed within last 14 days
QE tools team - closed within last 60 days
QE tools team - closed yesterday
QE Tools Team - Collaborative Session
QE tools team - due date forecast
QE Tools team - due soon
QE tools team - exceeding due-date
QE tools team - infrastructure backlog
QE tools team - next - sorted by update time
QE tools team - next issues
QE tools team - non-estimated (unblocked) issues (w/o infra)
QE tools team - ready issues - Workable
QE tools team - ready, not assigned/blocked/low
QE tools team - update forecast
QE tools team - updated by priority
QE tools team - what members of the team are working on - Feedback (not-low)
QE Tools Team Backlog By Assignee
Tools Team Retrospective
Tools Team Retrospective (not estimated or assigned)

Actions

Copy link

action #48578

open

openQA feature _SKIP_POST_FAIL_HOOKS also skips die()

Added by SLindoMansilla about 5 years ago. Updated over 3 years ago.

Status:

Feedback

Priority:

Low

Assignee:

asmorodskyi

Category:

Regressions/Crashes

Target version:

QA - future

Start date:

2019-03-01

Due date:

% Done:

Estimated time:

Description

Observation¶

openQA test in scenario sle-15-SP1-Installer-DVD-s390x-allpatterns@s390x-kvm-sle12 fails in
welcome

History
Notes
Property changes

Actions

Copy link

Updated by okurz about 5 years ago

Project changed from openQA Tests to openQA Project
Category changed from Bugs in existing tests to Regressions/Crashes
Priority changed from Normal to Low
Target version set to future

Actions

Copy link

Updated by okurz over 4 years ago

Status changed from New to Feedback
Assignee set to okurz

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.

https://github.com/os-autoinst/os-autoinst/pull/1228

Actions

Copy link

Updated by okurz over 4 years ago

Status changed from Feedback to Resolved

Actions

Copy link

Updated by SLindoMansilla over 4 years ago

Status changed from Resolved to Workable

okurz wrote:

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.

https://github.com/os-autoinst/os-autoinst/pull/1228

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.
This is issue is still not resolved for me. I can reopen this ticket or create a new one. [functional][u], so I am not requesting that you do it.

Actions

Copy link

Updated by okurz over 4 years ago

Subject changed from [functional][u] openQA feature _SKIP_POST_FAIL_HOOKS also skips die() to openQA feature _SKIP_POST_FAIL_HOOKS also skips die()
Assignee deleted (~~okurz~~)

SLindoMansilla wrote:

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.

I don't understand what you mean by that. Can you clarify?

Actions

Copy link

Updated by SLindoMansilla over 4 years ago

okurz wrote:

I don't understand what you mean by that. Can you clarify?

By default a module that fails will not abort the execution of following modules. When a module failure should abort the execution of following modules, then

sub test_flags {                                                                                                                                                                            
  return {fatal => 1}; 
}

is used.

This behavior is not respected when using _SKIP_POST_FAIL_HOOKS. So, it is not deciding if some would want to abort or not, it is about giving the openQA test developer the freedom to choose if the module should abort the job or not.

Actions

Copy link