https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842019-03-01T13:12:42ZopenSUSE Project Management ToolopenQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=1943962019-03-01T13:12:42Zokurzokurz@suse.com
<ul><li><strong>Project</strong> changed from <i>openQA Tests</i> to <i>openQA Project</i></li><li><strong>Category</strong> changed from <i>Bugs in existing tests</i> to <i>Regressions/Crashes</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li><li><strong>Target version</strong> set to <i>future</i></li></ul> openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=2496802019-10-14T15:57:29Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>okurz</i></li></ul><p>I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.</p>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1228" class="external">https://github.com/os-autoinst/os-autoinst/pull/1228</a></p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=2499862019-10-15T08:25:59Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul> openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=2500552019-10-15T08:42:18ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Workable</i></li></ul><p>okurz wrote:</p>
<blockquote>
<p>I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.</p>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1228" class="external">https://github.com/os-autoinst/os-autoinst/pull/1228</a></p>
</blockquote>
<p>If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.<br>
This is issue is still not resolved for me. I can reopen this ticket or create a new one. [functional][u], so I am not requesting that you do it.</p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=2500882019-10-15T09:19:23Zokurzokurz@suse.com
<ul><li><strong>Subject</strong> changed from <i>[functional][u] openQA feature _SKIP_POST_FAIL_HOOKS also skips die()</i> to <i>openQA feature _SKIP_POST_FAIL_HOOKS also skips die()</i></li><li><strong>Assignee</strong> deleted (<del><i>okurz</i></del>)</li></ul><p>SLindoMansilla wrote:</p>
<blockquote>
<p>If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.</p>
</blockquote>
<p>I don't understand what you mean by that. Can you clarify?</p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=2501842019-10-15T10:42:41ZSLindoMansillaslindomansilla@suse.com
<ul></ul><p>okurz wrote:</p>
<blockquote>
<p>I don't understand what you mean by that. Can you clarify?</p>
</blockquote>
<p>By default a module that fails will not abort the execution of following modules. When a module failure should abort the execution of following modules, then</p>
<pre><code class="perl syntaxhl" data-language="perl"><span class="k">sub </span><span class="nf">test_flags</span> <span class="p">{</span>
<span class="k">return</span> <span class="p">{</span><span class="s">fatal</span> <span class="o">=></span> <span class="mi">1</span><span class="p">};</span>
<span class="p">}</span>
</code></pre>
<p>is used.</p>
<p>This behavior is not respected when using _SKIP_POST_FAIL_HOOKS. So, it is not deciding if some would want to abort or not, it is about giving the openQA test developer the freedom to choose if the module should abort the job or not.</p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=3231072020-09-07T14:58:23Zasmorodskyi
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst/pull/1528" class="external">https://github.com/os-autoinst/os-autoinst/pull/1528</a></p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=3243582020-09-14T09:41:19Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>asmorodskyi</i></li></ul><p><a class="user active user-mention" href="https://progress.opensuse.org/users/23378">@asmorodskyi</a>, as discussed with you, as you are working on it, assigning to you</p>
openQA Project - action #48578: openQA feature _SKIP_POST_FAIL_HOOKS also skips die()https://progress.opensuse.org/issues/48578?journal_id=3252492020-09-18T06:24:24Zasmorodskyi
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>asmorodskyi wrote:</p>
<blockquote>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1528" class="external">https://github.com/os-autoinst/os-autoinst/pull/1528</a></p>
</blockquote>
<p>Pull request is merged and deployed on osd </p>