Project

General

Profile

action #48578

openQA feature _SKIP_POST_FAIL_HOOKS also skips die()

Added by SLindoMansilla over 2 years ago. Updated 10 months ago.

Status:
Feedback
Priority:
Low
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2019-03-01
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

openQA test in scenario sle-15-SP1-Installer-DVD-s390x-allpatterns@s390x-kvm-sle12 fails in
welcome

History

#1 Updated by okurz over 2 years ago

  • Project changed from openQA Tests to openQA Project
  • Category changed from Bugs in existing tests to Concrete Bugs
  • Priority changed from Normal to Low
  • Target version set to future

#2 Updated by okurz almost 2 years ago

  • Status changed from New to Feedback
  • Assignee set to okurz

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.

https://github.com/os-autoinst/os-autoinst/pull/1228

#3 Updated by okurz almost 2 years ago

  • Status changed from Feedback to Resolved

#4 Updated by SLindoMansilla almost 2 years ago

  • Status changed from Resolved to Workable

okurz wrote:

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.

https://github.com/os-autoinst/os-autoinst/pull/1228

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.
This is issue is still not resolved for me. I can reopen this ticket or create a new one. [functional][u], so I am not requesting that you do it.

#5 Updated by okurz almost 2 years ago

  • Subject changed from [functional][u] openQA feature _SKIP_POST_FAIL_HOOKS also skips die() to openQA feature _SKIP_POST_FAIL_HOOKS also skips die()
  • Assignee deleted (okurz)

SLindoMansilla wrote:

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.

I don't understand what you mean by that. Can you clarify?

#6 Updated by SLindoMansilla almost 2 years ago

okurz wrote:

I don't understand what you mean by that. Can you clarify?

By default a module that fails will not abort the execution of following modules. When a module failure should abort the execution of following modules, then

sub test_flags {                                                                                                                                                                            
  return {fatal => 1}; 
}

is used.

This behavior is not respected when using _SKIP_POST_FAIL_HOOKS. So, it is not deciding if some would want to abort or not, it is about giving the openQA test developer the freedom to choose if the module should abort the job or not.

#8 Updated by okurz 11 months ago

  • Status changed from Workable to In Progress
  • Assignee set to asmorodskyi

asmorodskyi, as discussed with you, as you are working on it, assigning to you

#9 Updated by asmorodskyi 10 months ago

  • Status changed from In Progress to Feedback

asmorodskyi wrote:

https://github.com/os-autoinst/os-autoinst/pull/1528

Pull request is merged and deployed on osd

Also available in: Atom PDF