action #48578
openopenQA feature _SKIP_POST_FAIL_HOOKS also skips die()
0%
Updated by okurz about 5 years ago
- Project changed from openQA Tests to openQA Project
- Category changed from Bugs in existing tests to Regressions/Crashes
- Priority changed from Normal to Low
- Target version set to future
Updated by okurz over 4 years ago
- Status changed from New to Feedback
- Assignee set to okurz
I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.
Updated by SLindoMansilla over 4 years ago
- Status changed from Resolved to Workable
okurz wrote:
I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.
If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.
This is issue is still not resolved for me. I can reopen this ticket or create a new one. [functional][u], so I am not requesting that you do it.
Updated by okurz over 4 years ago
- Subject changed from [functional][u] openQA feature _SKIP_POST_FAIL_HOOKS also skips die() to openQA feature _SKIP_POST_FAIL_HOOKS also skips die()
- Assignee deleted (
okurz)
SLindoMansilla wrote:
If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.
I don't understand what you mean by that. Can you clarify?
Updated by SLindoMansilla over 4 years ago
okurz wrote:
I don't understand what you mean by that. Can you clarify?
By default a module that fails will not abort the execution of following modules. When a module failure should abort the execution of following modules, then
sub test_flags {
return {fatal => 1};
}
is used.
This behavior is not respected when using _SKIP_POST_FAIL_HOOKS. So, it is not deciding if some would want to abort or not, it is about giving the openQA test developer the freedom to choose if the module should abort the job or not.
Updated by asmorodskyi over 3 years ago
Updated by okurz over 3 years ago
- Status changed from Workable to In Progress
- Assignee set to asmorodskyi
@asmorodskyi, as discussed with you, as you are working on it, assigning to you
Updated by asmorodskyi over 3 years ago
- Status changed from In Progress to Feedback
asmorodskyi wrote:
Pull request is merged and deployed on osd