action #48578

openQA feature _SKIP_POST_FAIL_HOOKS also skips die()

Added by SLindoMansilla about 1 year ago. Updated 6 months ago.

Status:WorkableStart date:01/03/2019
Priority:LowDue date:
Assignee:-% Done:

0%

Category:Concrete Bugs
Target version:QA - future
Difficulty:
Duration:

Description

Observation

openQA test in scenario sle-15-SP1-Installer-DVD-s390x-allpatterns@s390x-kvm-sle12 fails in
welcome

History

#1 Updated by okurz about 1 year ago

  • Project changed from openQA Tests to openQA Project
  • Category changed from Bugs in existing tests to Concrete Bugs
  • Priority changed from Normal to Low
  • Target version set to future

#2 Updated by okurz 6 months ago

  • Status changed from New to Feedback
  • Assignee set to okurz

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.

https://github.com/os-autoinst/os-autoinst/pull/1228

#3 Updated by okurz 6 months ago

  • Status changed from Feedback to Resolved

#4 Updated by SLindoMansilla 6 months ago

  • Status changed from Resolved to Workable

okurz wrote:

I don't think it would make sense to let jobs die on skip_post_fail_hook as then someone most likely would want the exact opposite. Instead I will document the implications.


https://github.com/os-autoinst/os-autoinst/pull/1228

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.
This is issue is still not resolved for me. I can reopen this ticket or create a new one. [functional][u], so I am not requesting that you do it.

#5 Updated by okurz 6 months ago

  • Subject changed from [functional][u] openQA feature _SKIP_POST_FAIL_HOOKS also skips die() to openQA feature _SKIP_POST_FAIL_HOOKS also skips die()
  • Assignee deleted (okurz)

SLindoMansilla wrote:

If someone wants their module to not fail using _SKIP_POST_FAIL_HOOKS, then os-autoinst already has "fatal" feature.

I don't understand what you mean by that. Can you clarify?

#6 Updated by SLindoMansilla 6 months ago

okurz wrote:

I don't understand what you mean by that. Can you clarify?

By default a module that fails will not abort the execution of following modules. When a module failure should abort the execution of following modules, then

sub test_flags {                                                                                                                                                                            
  return {fatal => 1}; 
}

is used.

This behavior is not respected when using _SKIP_POST_FAIL_HOOKS. So, it is not deciding if some would want to abort or not, it is about giving the openQA test developer the freedom to choose if the module should abort the job or not.

Also available in: Atom PDF