QA (public)

This one also looks useful:
https://github.com/probot/stale

The way to go is:

g = GitHub instance
org = g.get_organization('os-autoinst')
repo = org.get_repo('os-autoinst-distri-opensuse')
pr = repo.get_pull(numberOfPR)

Repo with the script:
https://github.com/DrMullings/Scripts-Snippets-Stuff/blob/master/Marvin/marvin.py

Progress so far:

• able to age of all PRs
• able to get age of comment of all PRs
• able to get if a PR is approved

The bot is now able to connect to IRC and GitHub, it can collect the data of all PRs and detect PRs in IRC
Need to talk to szarate later about how this should work exactly since just printing the PR state to IRC would be quite a mess

As discussed with szarate:

• Bot shall scan PRs and consider them stalled by a preconfigured parameter (e.g. 3-5 days for OpenQA Engineers, 2 weeks for external guys)
• based on the List of old PRs we write a weekly comment, mentioning last commentator to GitHub (Bot Comments, and Author Comments do not count)
• we can print a list of the old PRs to an IRC channel (best packaged in a command, e.g. "/bot give PRs older than 5 days")
• Bot can print the age of mentioned PRs in a channel

Stuff can now be found here:
https://github.com/DrMullings/Scripts-Snippets-Stuff/tree/master/Marvin

• It is not yet capable of differentiating between internal and external guys (we should re-discuss this anyway, it's hard to do from a technical side)
• It can write comments on a PR after the staletime is over
• The list of PRs could be printed to the IRC, this is not yet implemented though
• It checks the age (of the last comment) of posted PRs

I still need write access ID and Secret for os-autoinst to get it productive

As spoken with jrauch,

I think that a bot writing comments in the PRs will cause a lot of noise. People who didn't care about reviewing them will ignore those emails, or even complain (like it happened with bugzilla tickets).

Writing reminder in an IRC chat is better, since only people in that chat will receive the messages. We need to define yet who is taking care of reviewing PR. I think that our old model "each one does when she/he has time" has been proven to not work. We need a dedicated group of people for that. And, if at the end, this person will be only me, the bot will cause only noise, since I will ignore it and continue with my approach:

1. Look for tickets from U-Team on feedback
2. If it has a PR, review (eventually merging it)

We need to think of someone else as a backup while I am on vacation (if we want to have it). But, this bot will not change what we are already doing. If people don't review, the bot will not make them review.

One of the Ideas that come to mind with this, is that maybe we could introduce the Stale Probot and mark the pr's as stale, closing after 3 months of inactivity or so.

By now there are also more ideas based on github actions that can achieve something similar, e.g. https://github.com/actions/stale , similar to https://probot.github.io/apps/stale/ . I personally think that marking PRs as stale and eventually closing can be ok if done after a rather long time, e.g. months.

Bot is already working: https://github.com/os-autoinst/os-autoinst-distri-opensuse/labels/stale