action #40901
closed
make Makefile targets for tests easier (was: make target "docker.env" fails, probably grep -E 'FULLSTACK|UITEST|GH|TRAVIS|CPAN|DEBUG|ZYPPER' returns nothing for me)
Added by okurz over 5 years ago.
Updated about 4 years ago.
Category:
Feature requests
Description
When trying to call the local tests with docker the make target "docker.env" fails
make docker-test-run
env | grep -E 'FULLSTACK|UITEST|GH|TRAVIS|CPAN|DEBUG|ZYPPER' > "/home/okurz/local/os-autoinst/openQA/docker.env"
make: *** [Makefile:130: docker.env] Error 1
Sorry you run into this, we are in the middle of making tests more reliable / redefining our workflow. Can you confirm that the same happens when e.g. you enable specific subset of tests to be run?
UITESTS=1 make docker-test
or, any other test matrix?
the question is basically: what tests did you expect to run? all of them?
the original intention with the docker-test target was to not have to run all those commands before running the actual test (as it should also pull the docker image) and the others are shortcuts to do things manually in case the automatic one fails.
UITESTS=1 make docker-test works as it builds the docker image(s) and executes the UI testsmake docker-test builds again but does not execute any tests:
$ make docker-test
docker build --no-cache /home/okurz/local/os-autoinst/openQA/docker/openqa -t openqa:latest
…
Successfully built 0c2d773f3229
Successfully tagged openqa:latest
env | grep -E 'FULLSTACK|UITEST|GH|TRAVIS|CPAN|DEBUG|ZYPPER' > "/home/okurz/local/os-autoinst/openQA/docker.env"
make: *** [Makefile:130: docker.env] Error 1
make docker-test-run obviously skips the building and reproduces the last step failing
Yes, I expected it to run all tests or at least a "standard set" as the documentation https://github.com/os-autoinst/openQA/blob/master/docs/Contributing.asciidoc#how-to-run-tests-with-docker mentions this command.
- Subject changed from make target "docker.env" fails, probably grep -E 'FULLSTACK|UITEST|GH|TRAVIS|CPAN|DEBUG|ZYPPER' returns nothing for me to make Makefile targets for tests easier (was: make target "docker.env" fails, probably grep -E 'FULLSTACK|UITEST|GH|TRAVIS|CPAN|DEBUG|ZYPPER' returns nothing for me)
- Category changed from Support to Feature requests
- Status changed from New to Resolved
- Assignee set to okurz
done. After the move from travisci to circleci I cleaned up the Makefile and supporting scripts a lot and now
just works, setting up everything that is needed to run tests locally without containers again though running tests within containers is still supported though not automatically tested anymore as circleci handles containers by itself hence we also do not spawn the containers with our instructions.
We also have convenience targets, e.g.
- make test-t
- make test-fullstack
- make test-ui
- make test-checkstyle
etc.
Also available in: Atom
PDF